[clang] WIP: Improved Context Declaration trackingusers/mizvekov/clang-fix-lambda-context

This patch aims to improve how parenting relationships
are represented in the AST.

Currently regular declarations can only be children of
special AST nodes which inherit from DeclContext, except
for a few special cases which are required by itanium mangling.

Having this parenting relationship well described helps
in tracking which entities are dependent, and an improvement
here would allow us to drop a lot of workarounds and to
get some difficult cases right.

This patch extends the ContextDecl tracking which currently
is used for mangling, in order to cover almost needed cases.

Template type aliases represent a specially difficult case
which is addressed by this patch.
They can be contexts for other declarations, but besides not
being DeclContexts, they also lack a declaration which
represents their specialization.

This patch addresses the type alias context problem by
storing the specialization arguments along with the ContextDecl
for entities declared in their context.

TODO:

* Move away from using ExpressionEvaluationContexts, and use the same
stack used for tracking the CurContext. Remove the separate ContextDecl
field, and have that functionally built in to the base Decl class,
so that we don't separatelly treack both a parent Decl and a parent
DeclContext.

* A function type has ParmVarDecls, and these can appear inside
aliases and template type aliases in particular, so a ParmvarDecl
needs a ContextDecl too.

1 files changed, 1 insertions, 1 deletions

diff --git a/clang/lib/Sema/HLSLExternalSemaSource.cpp b/clang/lib/Sema/HLSLExternalSemaSource.cpp
index 071e64fe56d4..4102258e0b57 100644
--- a/clang/lib/Sema/HLSLExternalSemaSource.cpp
+++ b/clang/lib/Sema/HLSLExternalSemaSource.cpp
@@ -264,7 +264,7 @@ struct BuiltinTypeDeclBuilder {
         AST, MethodDecl->getDeclContext(), SourceLocation(), SourceLocation(),
         &II, AST.UnsignedIntTy,
         AST.getTrivialTypeSourceInfo(AST.UnsignedIntTy, SourceLocation()),
-        SC_None, nullptr);
+        SC_None, nullptr, MethodDecl->getTemplateDepth());
     MethodDecl->setParams({IdxParam});
 
     // Also add the parameter to the function prototype.