diff options
| author | Michael Liao <michael.hliao@gmail.com> | 2020-03-18 01:43:20 -0400 |
|---|---|---|
| committer | Michael Liao <michael.hliao@gmail.com> | 2020-03-18 09:33:39 -0400 |
| commit | 4cf01ed75e35e7bd3ef8ef1a2192c7f4656ab545 (patch) | |
| tree | d8beff76e8f9ef5be3173042612d5da5464eb921 /clang/lib/CodeGen/CGExpr.cpp | |
| parent | 6739805e24cda6c75d36a78072cfca9033c28c51 (diff) | |
[hip] Revise `GlobalDecl` constructors. NFC.
Summary:
- https://reviews.llvm.org/D68578 revises the `GlobalDecl` constructors
to ensure all GPU kernels have `ReferenceKenelKind` initialized
properly with an explicit constructor and static one. But, there are
lots of places using the implicit constructor triggering the assertion
on non-GPU kernels. That's found in compilation of many tests and
workloads.
- Fixing all of them may change more code and, more importantly, all of
them assumes the default kernel reference kind. This patch changes
that constructor to tell `CUDAGlobalAttr` and construct `GlobalDecl`
properly.
Reviewers: yaxunl
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D76344
Diffstat (limited to 'clang/lib/CodeGen/CGExpr.cpp')
| -rw-r--r-- | clang/lib/CodeGen/CGExpr.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp index a3399af183b5..6457852f1b6d 100644 --- a/clang/lib/CodeGen/CGExpr.cpp +++ b/clang/lib/CodeGen/CGExpr.cpp @@ -4678,12 +4678,12 @@ CGCallee CodeGenFunction::EmitCallee(const Expr *E) { // Resolve direct calls. } else if (auto DRE = dyn_cast<DeclRefExpr>(E)) { if (auto FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { - return EmitDirectCallee(*this, CGM.getGlobalDecl(FD)); + return EmitDirectCallee(*this, FD); } } else if (auto ME = dyn_cast<MemberExpr>(E)) { if (auto FD = dyn_cast<FunctionDecl>(ME->getMemberDecl())) { EmitIgnoredExpr(ME->getBase()); - return EmitDirectCallee(*this, CGM.getGlobalDecl(FD)); + return EmitDirectCallee(*this, FD); } // Look through template substitutions. |
