summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornerix <nerixdev@outlook.de>2025-08-14 15:23:39 +0200
committerGitHub <noreply@github.com>2025-08-14 14:23:39 +0100
commit7bda76367f19cfc19086f68d9dd5ac019a9ceccd (patch)
tree818072876a460f16bcf57b0d7c969f468abecd12
parent179698a0fb0c4496533e190fb89238bf929dd8f8 (diff)
[LLDB][NativePDB] Ignore functions with no type in name lookup (#153382)
Some functions don't have the `FunctionType` set. We can't look these up and won't be able to call them, so ignore them when caching the function names. This does fix the failures caused by https://github.com/llvm/llvm-project/pull/153160 mentioned in https://github.com/llvm/llvm-project/pull/153160#issuecomment-3183062431. However, in `lldb-shell::msstl_smoke.cpp` there's another failure not introduced by #153160 (fixed with #153386).
-rw-r--r--lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp b/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
index 108e439317b7..112eb06e462f 100644
--- a/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
+++ b/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
@@ -1688,7 +1688,7 @@ void SymbolFileNativePDB::CacheFunctionNames() {
llvm::cantFail(SymbolDeserializer::deserializeAs<ProcSym>(*iter));
if ((proc.Flags & ProcSymFlags::IsUnreachable) != ProcSymFlags::None)
continue;
- if (proc.Name.empty())
+ if (proc.Name.empty() || proc.FunctionType.isSimple())
continue;
// The function/procedure symbol only contains the demangled name.