llvm-project.git/llvm/utils/FileCheck/FileCheck.cpp, branch users/nico/python-2

[llvm][utils] Avoid 'raw_string_ostream::str()' (NFC) (#97160)

2024-06-29T22:50:52+00:00

Since `raw_string_ostream` doesn't own the string buffer, it is
desirable (in terms of memory safety) for users to directly reference
the string buffer rather than use `raw_string_ostream::str()`.

Work towards TODO comment to remove `raw_string_ostream::str()`.

Add llvm::min/max_element and use it in llvm/ and mlir/ directories. (#84678)

2024-03-11T03:00:13+00:00

For some reason this was missing from STLExtras.

[FileCheck] Don't use regex to find prefixes (#72237)

2023-11-15T08:34:52+00:00

FileCheck currently compiles a regular expression of the form
`Prefix1|Prefix2|...` and uses it to find the next prefix in the input.

If we had a fast regex implementation, this would be a useful thing to
do, as the regex implementation would be able to match multiple prefixes
more efficiently than a naive approach. However, with our actual regex
implementation, finding the prefixes basically becomes O(InputLen *
RegexLen * LargeConstantFactor), which is a lot worse than a simple
string search.

Replace the regex with StringRef::find(), and keeping track of the next
position of each prefix. There are various ways this could be improved
on, but it's already significantly faster that the previous approach.

For me, this improves check-llvm time from 138.5s to 132.5s, so by
around 4-5%.

For vector-interleaved-load-i16-stride-7.ll in particular, test time
drops from 5s to 2.5s.

[FileCheck] Fix performance-for-range-copy issues. NFC

2023-09-27T20:34:41+00:00

[llvm] Remove unneeded cl::ZeroOrMore for cl::opt options. NFC

2022-06-04T04:59:05+00:00

Some cl::ZeroOrMore were added to avoid the `may only occur zero or one times!`
error. More were added due to cargo cult. Since the error has been removed,
cl::ZeroOrMore is unneeded.

Also remove cl::init(false) while touching the lines.

[FileCheck] GetCheckTypeAbbreviation() to handle the misspelled case.

2022-05-26T11:20:15+00:00

Also fix directives not covered by D125604.

Cleanup includes: DebugInfo & CodeGen

2022-03-12T16:26:40+00:00

Discourse thread: https://discourse.llvm.org/t/include-what-you-use-include-cleanup
Differential Revision: https://reviews.llvm.org/D121332

[FileCheck] Fix initialized but never used static analyzer warning. NFC.

2022-02-10T21:03:45+00:00

Remove superfluous variable initialization, the variable is assigned by both paths immediately afterward.

utils: Remove some no-op raw_string_ostream flush calls, NFC

2021-12-10T19:26:08+00:00

Since 65b13610a5226b84889b923bae884ba395ad084d, raw_string_ostream has
been unbuffered by default. Based on an audit of llvm/utils/, this
commit removes every call to `raw_string_ostream::flush()` and any call
to `raw_string_ostream::str()` whose result is ignored or that doesn't
help with clarity.

I left behind a few calls to `str()`. In these cases, the underlying
std::string was declared pretty far away and never used again, whereas
stream recently had its last write. The code is easier to read as-is;
the no-op call to `flush()` inside `str()` isn't harmful, and when
https://reviews.llvm.org/D115421 lands it'll be gone anyway.

[FileCheck] Try to fix buildbot failures caused by c7c542e8f306

2021-03-27T15:03:10+00:00

For example,



has this diagnostic:

```
/opt/gcc/9.3.0/snos/include/g++/bits/stl_tree.h:780:8: error: static assertion failed: comparison object must be invocable as const
  780 |        is_invocable_v,
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```