llvm-project.git/llvm/test/Transforms/EmbedBitcode/embed-wpd.ll, branch users/nico/python-2 Unnamed repository; edit this file 'description' to name the repository. Revert "[llvm][EmbedBitcodePass] Prevent modifying the module with ThinLTO" (#145987) 2025-06-27T05:35:38+00:00 Paul Kirth paulkirth@google.com 2025-06-27T05:35:38+00:00 9179322447143f0d78232a6005ceb4d6655c83d8 Reverts llvm/llvm-project#139999 This has a reported crash in https://github.com/llvm/llvm-project/pull/139999#issuecomment-2993622494 This PR was intended to fix an error when linking, which is unfortunately preferable to crashing clang. For now, we'll revert and investigate the problem. 
Reverts llvm/llvm-project#139999

This has a reported crash in
https://github.com/llvm/llvm-project/pull/139999#issuecomment-2993622494

This PR was intended to fix an error when linking, which is
unfortunately preferable to crashing clang. For now, we'll revert and
investigate the problem.
 [llvm][EmbedBitcodePass] Prevent modifying the module with ThinLTO (#139999) 2025-05-29T20:42:48+00:00 Paul Kirth paulkirth@google.com 2025-05-29T20:42:48+00:00 55c7d5cdadc4dd0fab843992e0fb31ef7ea6fda4 Since ThinLTOBitcodeWriterPass handles many things for CFI and WPD, like updating vtable linkage, we need to prevent those changes from persisting in the non-LTO object code we will compile under FatLTO. The only non-invasive way to do that is to clone the module when serializing the module in ThinLTOBitcodeWriterPass. We may be able to avoid cloning in the future with additional infrastructure to restore the IR to its original state. Fixes #139440 
Since ThinLTOBitcodeWriterPass handles many things for CFI and WPD, like
updating vtable linkage, we need to prevent those changes from
persisting in the non-LTO object code we will compile under FatLTO.

The only non-invasive way to do that is to clone the module when
serializing the module in ThinLTOBitcodeWriterPass. We may be able to
avoid cloning in the future with additional infrastructure to restore
the IR to its original state.

Fixes #139440
 [llvm][EmbedBitcodePass] Pre-commit test for using WPD with FatLTO (#139998) 2025-05-29T20:39:45+00:00 Paul Kirth paulkirth@google.com 2025-05-29T20:39:45+00:00 bedbc65871828f0f3f0a7e25d38af2867e8c546c This is a reduced test case from #139440. 
This is a reduced test case from #139440.