llvm-project.git/llvm/test/FileCheck/empty-variable-name.txt, branch users/nico/python-2 Unnamed repository; edit this file 'description' to name the repository. [FileCheck] Fix parsing empty global and pseudo variable names (#83667) 2024-03-05T08:20:16+00:00 Daniil Kovalev dkovalev@accesssoftek.com 2024-03-05T08:20:16+00:00 3105cfe783d861e63c647469cc3a6c9b91f8bb4a Reland #82595 with fixes of build failures related to colored output. See https://lab.llvm.org/buildbot/#/builders/139/builds/60549 Use `%ProtectFileCheckOutput` to avoid colored output. Original commit message below. In `Pattern::parseVariable`, for global variables (those starting with '$') and for pseudo variables (those starting with '@') the first character is consumed before actual variable name parsing. If the name is empty, it leads to out-of-bound access to the corresponding `StringRef`. This patch adds an if statement against the case described. 
Reland #82595 with fixes of build failures related to colored output.
See https://lab.llvm.org/buildbot/#/builders/139/builds/60549
Use `%ProtectFileCheckOutput` to avoid colored output.
Original commit message below.

In `Pattern::parseVariable`, for global variables (those starting with '$')
and for pseudo variables (those starting with '@') the first character is
consumed before actual variable name parsing. If the name is empty, it
leads to out-of-bound access to the corresponding `StringRef`.

This patch adds an if statement against the case described.
 Revert "[FileCheck] Fix parsing empty global and pseudo variable names" (#83657) 2024-03-02T05:09:10+00:00 Daniil Kovalev dkovalev@accesssoftek.com 2024-03-02T05:09:10+00:00 28b354a96054196cc3c50c2517b0509d0d316d42 Reverts llvm/llvm-project#82595 See build failure https://lab.llvm.org/buildbot/#/builders/139/builds/60549 
Reverts llvm/llvm-project#82595

See build failure
https://lab.llvm.org/buildbot/#/builders/139/builds/60549
 [FileCheck] Fix parsing empty global and pseudo variable names (#82595) 2024-03-02T04:03:50+00:00 Daniil Kovalev dkovalev@accesssoftek.com 2024-03-02T04:03:50+00:00 aab3d13179dc5a37465a0e6fbf1b9369a4e6e50f In `Pattern::parseVariable`, for global variables (those starting with '$') and for pseudo variables (those starting with '@') the first character is consumed before actual variable name parsing. If the name is empty, it leads to out-of-bound access to the corresponding `StringRef`. This patch adds an if statement against the case described. 
In `Pattern::parseVariable`, for global variables (those starting with
'$') and for pseudo variables (those starting with '@') the first
character is consumed before actual variable name parsing. If the name
is empty, it leads to out-of-bound access to the corresponding
`StringRef`.

This patch adds an if statement against the case described.