llvm-project.git/llvm/test/DebugInfo/KeyInstructions/Generic, branch users/nico/python-2

[KeyInstr] Add DISubprogram::keyInstructions bit (#144107)

2025-06-30T07:01:55+00:00

Patch 1/4 adding bitcode support.

Store whether or not a function is using Key Instructions in its DISubprogram so
that we don't need to rely on the -mllvm flag -dwarf-use-key-instructions to
determine whether or not to interpret Key Instructions metadata to decide
is_stmt placement at DWARF emission time. This makes bitcode support simple and
enables well defined mixing of non-key-instructions and key-instructions
functions in an LTO context.

This patch adds the bit (using DISubprogram::SubclassData1).

PR 144104 and 144103 use it during DWARF emission.
PR 44102 adds bitcode
support.

See pull request for overview of alternative attempts.

[KeyInstr][LoopUnswitch] Remap cloned instructions' atoms (#133491)

2025-05-09T14:24:47+00:00

RFC: https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668

[KeyInstr][JumpThreading] Remap atoms after threading (#133487)

2025-05-09T12:48:23+00:00

RFC: https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668

[KeyInstr][LoopUnroll] Remap atoms while unrolling (#133489)

2025-05-09T12:47:16+00:00

RFC: https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668

[KeyInstr][LoopRotate] Remap atoms of duplicated instructions (#133490)

2025-05-07T16:10:30+00:00

RFC: https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668

[KeyInstr][JumpThreading] Remap atoms duping bb with cond br on phi into pred (#133488)

2025-05-07T15:01:53+00:00

See test for details.

[KeyInstr][JumpThreading] Remap atoms in blocks duplicated for threading (#133486)

2025-05-07T13:54:04+00:00

[KeyInstr][Inline] Don't propagate atoms to inlined nodebug instructions (#133485)

2025-05-07T10:54:57+00:00

RFC: https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668

[KeyInstr][SimplifyCFG] Remap atoms after duplication for threading (#133484)

2025-05-07T08:56:30+00:00

Given the same branch condition in `a` and `c` SimplifyCFG converts:

        +> b -+
        |     v
    --> a --> c --> e -->
              |     ^
              +> d -+
into:

        +--> bcd ---+
        |           v
    --> a --> c --> e -->

Remap source atoms on instructions duplicated from `c` into `bcd`.

RFC:
https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668

[KeyInstr][SimplifyCFG] Remap atoms when folding br to common succ into pred (#133482)

2025-05-06T14:03:20+00:00

SimplifyCFG folds `d` into preds `b` and `c`.

              +---------------+
              |               |
         +--> b --+           |
         |        v           v
     --> a        d --> e --> f -->
         |        ^           ^
         +--> c --+           |
              |               |
              +---------------+
    
Remap source atoms so that the duplicated instructions are analysed
independently to determine is_stmt positions.

The pull request contains a discussion covering various edge cases here:
https://github.com/llvm/llvm-project/pull/133482/files#r2039519348

The summary of the discussion is that we could avoid remapping when there's a
single pred, but we decided that it's still a trade off, and not worth the
additional complexity right now.

RFC:
https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668