llvm-project.git/llvm/lib/Transforms/IPO/ModuleInliner.cpp, branch users/nico/python-2 Unnamed repository; edit this file 'description' to name the repository. [ctxprof] Use `isInSpecializedModule` as criteria for using contextual profile (#134468) 2025-04-08T02:55:00+00:00 Mircea Trofin mtrofin@google.com 2025-04-08T02:55:00+00:00 f1bb2fe3562d2fe9a43c79ec8af908fdff23a33a After #134340, the availability of contextual profile isn't in itself an indication of compiling the module containing all the functions covered by that profile. 
After #134340, the availability of contextual profile isn't in itself an indication of compiling the module containing all the functions covered by that profile.
 [ctxprof][nfc] Prepare CtxProfAnalysis for flat profiles (#129623) 2025-03-05T00:42:47+00:00 Mircea Trofin mtrofin@google.com 2025-03-05T00:42:47+00:00 2068a18c86ab0f6f80e268dc3bc1a5329ee51715 Mostly remove the equivalence "no contexts == no CtxProfAnalysis result", and instead check explicitly there are no contextual profiles. 
Mostly remove the equivalence "no contexts == no CtxProfAnalysis result", and instead check explicitly there are no contextual profiles.
 [NFC]Make file-local cl::opt global variables static (#126486) 2025-03-03T06:46:33+00:00 chrisPyr 32153107+chrisPyr@users.noreply.github.com 2025-03-03T06:46:33+00:00 71f4c7dabec0f32b2d475e8e08f0da99628a067c #125983 
#125983
 [ctx_prof] Simple ICP criteria during module inliner (#109881) 2024-09-25T22:05:52+00:00 Mircea Trofin mtrofin@google.com 2024-09-25T22:05:52+00:00 c8365feed7af6d17cd2cc04cdc7fe0247f87e9c8 This is mostly for test: under contextual profiling, we perform ICP for those indirect callsites which have targets marked as `alwaysinline`. This helped uncover a bug with the way the profile was updated upon ICP, where we were skipping over the update if the target wasn't called in that context. That was resulting in incorrect counts for the indirect BB. Also flyby fix to the total/direct count values, they should be 64-bit (as all counters are in the contextual profile) 
This is mostly for test: under contextual profiling, we perform ICP for those indirect callsites which have targets marked as `alwaysinline`.

This helped uncover a bug with the way the profile was updated upon ICP, where we were skipping over the update if the target wasn't called in that context. That was resulting in incorrect counts for the indirect BB.

Also flyby fix to the total/direct count values, they should be 64-bit (as all counters are in the contextual profile)
 [ctx_prof] Insert the ctx prof flattener after the module inliner (#107499) 2024-09-10T01:16:24+00:00 Mircea Trofin mtrofin@google.com 2024-09-10T01:16:24+00:00 3b2261809471a018de50e745c0d475b048c66fd4 This patch enables experimenting with the contextual profile. ICP is currently disabled in this case - will reenable it subsequently. Also subsequently the inline cost model / decision making would be updated to be context-aware. Right now, this just achieves "complete use" of the profile, in that it's ingested, maintained, and sunk to a flat profile when not needed anymore. Issue [#89287](https://github.com/llvm/llvm-project/issues/89287) 
This patch enables experimenting with the contextual profile. ICP is currently disabled in this case - will reenable it subsequently. Also subsequently the inline cost model / decision making would be updated to be context-aware. Right now, this just achieves "complete use" of the profile, in that it's ingested, maintained, and sunk to a flat profile when not needed anymore.

Issue [#89287](https://github.com/llvm/llvm-project/issues/89287)
 [ctx_prof] Add Inlining support (#106154) 2024-09-03T23:14:05+00:00 Mircea Trofin mtrofin@google.com 2024-09-03T23:14:05+00:00 3209766608d14fbb0add96916a28c3f98fed9460 Add an overload of `InlineFunction` that updates the contextual profile. If there is no contextual profile, this overload is equivalent to the non-contextual profile variant. Post-inlining, the update mainly consists of: - making the PGO instrumentation of the callee "the caller's": the owner function (the "name" parameter of the instrumentation instructions) becomes the caller, and new index values are allocated for each of the callee's indices (this happens for both increment and callsite instrumentation instructions) - in the contextual profile: - each context corresponding to the caller has its counters updated to incorporate the counters inherited from the callee at the inlined callsite. Counter values are copied as-is because no scaling is required since the profile is contextual. - the contexts of the callee (at the inlined callsite) are moved to the caller. - the callee context at the inlined callsite is deleted. 
Add an overload of `InlineFunction` that updates the contextual profile. If there is no contextual profile, this overload is equivalent to the non-contextual profile variant.

Post-inlining, the update mainly consists of:
- making the PGO instrumentation of the callee "the caller's": the owner function (the "name" parameter of the instrumentation instructions) becomes the caller, and new index values are allocated for each of the callee's indices (this happens for both increment and callsite instrumentation instructions)
- in the contextual profile:
   - each context corresponding to the caller has its counters updated to incorporate the counters inherited from the callee at the inlined callsite. Counter values are copied as-is because no scaling is required since the profile is contextual.
   - the contexts of the callee (at the inlined callsite) are moved to the caller.
   - the callee context at the inlined callsite is deleted.
 [ModuleInliner] Remove an inapplicable comment 2023-05-28T05:26:37+00:00 Kazu Hirata kazu@google.com 2023-05-28T05:26:37+00:00 65f40cb455f8eaf83c163793d19640b56393c1e5 The module inliner has its own logic in deciding the order in which call sites are inlined, so the comment is inapplicable. 
The module inliner has its own logic in deciding the order in which
call sites are inlined, so the comment is inapplicable.
[AlwaysInliner] Make legacy pass like the new pass 2023-03-21T18:04:22+00:00 Arthur Eubanks aeubanks@google.com 2023-03-20T18:18:35+00:00 fa6ea7a419f37befbed04368bcb8af4c718facbb The legacy pass is only used in AMDGPU codegen, which doesn't care about running it in call graph order (it actually has to work around that fact). Make the legacy pass a module pass and share code with the new pass. This allows us to remove the legacy inliner infrastructure. Reviewed By: mtrofin Differential Revision: https://reviews.llvm.org/D146446 
The legacy pass is only used in AMDGPU codegen, which doesn't care about running it in call graph order (it actually has to work around that fact).

Make the legacy pass a module pass and share code with the new pass.

This allows us to remove the legacy inliner infrastructure.

Reviewed By: mtrofin

Differential Revision: https://reviews.llvm.org/D146446
[InlineOrder] Plugin Inline Order 2023-03-15T17:15:14+00:00 ibricchi ibricchi@student.ethz.ch 2023-03-15T17:14:27+00:00 65f7ebe72e4ca1b788e13dfbd2f71b5beeffba7d Adds the ability to load a plugin to control the inline order. This allows developing and distributing inlining heuristics outside of tree. And together with the inline advisor plugins allows for fine grained control of the inliner. The PluginInlineOrderAnalysis class serves as the entry point for dynamic advisors. Plugins must register instances of this class to provide their own InlineOrder. Reviewed By: kazu Differential Revision: https://reviews.llvm.org/D140637 
Adds the ability to load a plugin to control the inline order.
This allows developing and distributing inlining heuristics
outside of tree. And together with the inline advisor plugins
allows for fine grained control of the inliner.

The PluginInlineOrderAnalysis class serves as the entry point
for dynamic advisors. Plugins must register instances of this
class to provide their own InlineOrder.

Reviewed By: kazu

Differential Revision: https://reviews.llvm.org/D140637
Revert "[InlineOrder] Plugin Inline Order" 2023-03-15T17:12:04+00:00 Jake Egan jake.egan@ibm.com 2023-03-15T17:12:04+00:00 1628a5695e329903efc71d6fbe6eb0392639ad7e This commit is causing a CMake error on AIX. Will recommit with a fix. This reverts commit e46d8a731535afcf0c5c2a2f6cf3c5d4fb69cd5b. 
This commit is causing a CMake error on AIX. Will recommit with
a fix.

This reverts commit e46d8a731535afcf0c5c2a2f6cf3c5d4fb69cd5b.