llvm-project.git/llvm/lib/Target/AMDGPU/AMDGPUAlwaysInlinePass.cpp, branch users/nico/python-2

[NFC][AMDGPU] Replace direct arch comparison with `isAMDGCN()` (#131357)

2025-03-14T18:21:44+00:00

[AMDGPU] Always Inline preserved analyses (#91198)

2024-05-09T10:17:01+00:00

When replacing all uses, the structural-hash of the IR can change, so
keep track of changes using Changed variable and return it to pass
manager.

[amdgpu] Implement dynamic LDS accesses from non-kernel functions

2023-04-04T19:06:34+00:00

The premise here is to allow non-kernel functions to locate external LDS variables without using LDS or extra magic SGPRs to do so.

1/ First it crawls the callgraph to work out which external LDS variables are reachable from a given kernel
2/ Then it creates a new `extern char[0]` variable for each kernel, which will alias all the other extern LDS variables because that's the documented behaviour of these variables
3/ The address of that variable is written to a lookup table. The global variable is tagged with metadata to track what address it was allocated at by codegen
4/ The assembler builds the lookup table using the metadata
5/ Any non-kernel functions use the same magic intrinsic used by table lookups of non-dynamic LDS variables to find the address to use

Heavy overlap with the code paths taken for other lowering, in particular the same intrinsic is used to pass the dynamic scope information through the same sgpr as for table lookups of static LDS.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D144233

[HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

2021-10-18T22:53:15+00:00

By default clang emits complete contructors as alias of base constructors if they are the same.
The backend is supposed to emit symbols for the alias, otherwise it causes undefined symbols.
@yaxunl observed that this issue is related to the llvm options `-amdgpu-early-inline-all=true`
and `-amdgpu-function-calls=false`. This issue is resolved by only inlining global values
with internal linkage. The `getCalleeFunction()` in AMDGPUResourceUsageAnalysis also had
to be extended to support aliases to functions. inline-calls.ll was corrected appropriately.

Reviewed By: yaxunl, #amdgpu

Differential Revision: https://reviews.llvm.org/D109707

Revert "[HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols"

2021-10-15T22:16:18+00:00

This reverts commit 03375a3fb33b11e1249d9c88070b7f33cb97802a.

[HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

2021-10-15T17:39:15+00:00

By default clang emits complete contructors as alias of base constructors if they are the same.
The backend is supposed to emit symbols for the alias, otherwise it causes undefined symbols.
@yaxunl observed that this issue is related to the llvm options `-amdgpu-early-inline-all=true`
and `-amdgpu-function-calls=false`. This issue is resolved by only inlining global values
with internal linkage. The `getCalleeFunction()` in AMDGPUResourceUsageAnalysis also had
to be extended to support aliases to functions. inline-calls.ll was corrected appropriately.

Reviewed By: yaxunl, #amdgpu

Differential Revision: https://reviews.llvm.org/D109707

[AMDGPU][NFC] Correct typos in lib/Target/AMDGPU/AMDGPU*.cpp files. Test commit for new contributor.

2021-09-20T21:48:50+00:00

[AMDGPU] Inline non-kernel functions using extern lds

2021-09-16T17:58:51+00:00

In https://reviews.llvm.org/D100481, forceful inline of all non-kernel
functions using lds was disabled since AMDGPULowerModuleLDS pass now handles
static lds. However that pass does not handle extern lds so non-kernel
functions using extern lds must sill be inline.

Reviewed By: hsmhsm, arsenm

Differential Revision: https://reviews.llvm.org/D109773

[AMDGPU] Disable forceful inline of non-kernel functions which use LDS.

2021-04-15T03:42:56+00:00

Now since LDS uses within non-kernel functions are being handled in the
pass - LowerModuleLDS, we *NO* need to *forcefully* inline non-kernel
functions just because they use LDS. Do forceful inlining only when the
pass - LowerModuleLDS is not enabled. It is enabled by default.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D100481

[Target] Use llvm::append_range (NFC)

2021-01-24T20:18:56+00:00