llvm-project.git/llvm/lib/Support/Statistic.cpp, branch main

[Timer][Statistics] Make global constructor ordering more robust

2022-08-25T17:09:49+00:00

It was observed in D129117 that the subtle dependency between statistic
and timer code is not entirely robust: the global destructor
~StatisticInfo indirectly calls CreateInfoOutputFile, which requires
the LibSupportInfoOutputFilename to not have been destructed.

By constructing LibSupportInfoOutputFilename before the StatisticInfo
object, the order of destruction is guaranteed.

Differential Revision: https://reviews.llvm.org/D131059

[Support] Drop unnecessary const from a return type (NFC)

2022-08-14T19:51:56+00:00

Identified with readability-const-return-type.

[Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned.

2022-06-22T17:11:40+00:00

Binary size of `clang` is trivial; namely, numerical value doesn't
change when measured in MiB, and `.data` section increases from 139Ki to
173 Ki.

Differential Revision: https://reviews.llvm.org/D128070

[Support] Use range-based for loops (NFC)

2021-12-10T16:53:14+00:00

Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

2021-07-16T07:38:16+00:00

We can build it with -Werror=global-constructors now. This helps
in situation where libSupport is embedded as a shared library,
potential with dlopen/dlclose scenario, and when command-line
parsing or other facilities may not be involved. Avoiding the
implicit construction of these cl::opt can avoid double-registration
issues and other kind of behavior.

Reviewed By: lattner, jpienaar

Differential Revision: https://reviews.llvm.org/D105959

Revert "Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer"

2021-07-16T07:35:13+00:00

This reverts commit af9321739b20becf170e6bb5060b8d780e1dc8dd.
Still some specific config broken in some way that requires more
investigation.

Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

2021-07-16T06:54:26+00:00

We can build it with -Werror=global-constructors now. This helps
in situation where libSupport is embedded as a shared library,
potential with dlopen/dlclose scenario, and when command-line
parsing or other facilities may not be involved. Avoiding the
implicit construction of these cl::opt can avoid double-registration
issues and other kind of behavior.

Reviewed By: lattner, jpienaar

Differential Revision: https://reviews.llvm.org/D105959

Revert "Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer"

2021-07-16T03:46:53+00:00

This reverts commit 42f588f39c5ce6f521e3709b8871d1fdd076292f.
Broke some buildbots

Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

2021-07-16T03:33:20+00:00

We can build it with -Werror=global-constructors now. This helps
in situation where libSupport is embedded as a shared library,
potential with dlopen/dlclose scenario, and when command-line
parsing or other facilities may not be involved. Avoiding the
implicit construction of these cl::opt can avoid double-registration
issues and other kind of behavior.

Reviewed By: lattner, jpienaar

Differential Revision: https://reviews.llvm.org/D105959

Fix "Statistics are disabled"

2020-06-03T23:10:09+00:00

There is no -DLLVM_ENABLE_STATS, only
-DLLVM_FORCE_ENABLE_STATS.
It was renamed by 6cf299cf01e4a83844126f7faf17cbeb78e88da9