Calls to the posix `write` function can return -1 and set errno to `EINTR` or perform partial writes when interrupted by signals. In those cases applications are supposed to just try again. See for example the documentation in glibc: https://sourceware.org/glibc/manual/latest/html_node/I_002fO-Primitives.html#index-write This fixes the uses in `ErrorHandling.cpp` to retry as needed.
This implements the result of the discussion at: https://discourse.llvm.org/t/rfc-report-fatal-error-and-the-default-value-of-gencrashdialog/73587 There are two different use cases for report_fatal_error, so replace it with two functions reportFatalInternalError() and reportFatalUsageError(). The former indicates a bug in LLVM and generates a crash dialog. The latter does not. The names have been suggested by rnk and people seemed to like them. This replaces a lot of the usages that passed an explicit value for GenCrashDiag. I did not bulk replace remaining report_fatal_error usage -- they probably require case by case review for which function to use.
In 1e53f9523d3d5fcb2993b4b6540f1ed8d743380b, the FileSystem.h header was changed to always include <sys/stat.h>, while it previously only was included if HAVE_SYS_STAT_H was defined. HAVE_SYS_STAT_H was defined in llvm/Config/config.h, while FileSystem.h only included llvm/Config/llvm-config.h. Thus, <sys/stat.h> was only being included in some but not all cases. The change to always include <sys/stat.h> broke compiling LLDB for MinGW targets, because the MinGW <sys/stat.h> header adds an "#define fstat _fstat64" define, which breaks LLDBs use of a struct with a member named "fstat". Remove the include of <sys/stat.h> in FileSystem.h, as it seems to not be necessary in practice, fixing compilation of LLDB for MinGW targets. Change one instance of defined(_MSC_VER) into defined(_WIN32) in ErrorHandling.cpp to get <io.h> included; this source file did include config.h before transitively including FileSystem.h. The include of <sys/stat.h> in FileSystem.h would bring in <io.h> (needed for ::write()), explaining why this ifdef didn't need to cover MinGW before.
Without these explicit includes, removing other headers, who implicitly include llvm-config.h, may have non-trivial side effects.
If a delete is pending on the file queried for status, a misleading `permission_denied` error code will be returned (this is the correct mapping of the error set by GetFileAttributesW). By querying the underlying NTSTATUS code via ntdll's RtlGetLastNtStatus, this case can be disambiguated. If this underlying error code indicates a pending delete, fs::status will return a new `pending_delete` error code to be handled by callers Fixes #89137
Previously, the function `install_bad_alloc_error_handler` was asserting that a bad_alloc error handler was not already installed. However, it was actually checking for the fatal-error handler, not for the bad_alloc error handler, causing an assertion failure if a fatal-error handler was already installed. Fixes #83040
doesn't like exit code 126 I'm afraid
There are a few places where we use report_fatal_error when the input is broken. Currently, this function always crashes LLVM with an abort signal, which then triggers the backtrace printing code. I think this is excessive, as wrong input shouldn't give a link to LLVM's github issue URL and tell users to file a bug report. We shouldn't print a stack trace either. This patch changes report_fatal_error so it uses exit() rather than abort() when its argument GenCrashDiag=false. Reviewed by: nikic, MaskRay, RKSimon Differential Revision: https://reviews.llvm.org/D126550
Also sort ERROR_BAD_NETPATH correctly. Compared with the similar error code mapping in libcxx/src/filesystem/operations.cpp, I'm leaving out mappings for ERROR_NOT_SAME_DEVICE and ERROR_OPERATION_ABORTED. They map nicely to std::errc::cross_device_link and std::errc::operation_canceled, but those aren't available in llvm::errc, as they aren't available across all platforms. Also, the libcxx version maps ERROR_INVALID_NAME to no_such_file_or_directory instead of invalid_argument. Differential Revision: https://reviews.llvm.org/D111874
As described on D111049, removing the <string> dependency from error handling removes considerable build overhead, its recommended that the report_fatal_error(Twine) variant is used instead.