These are identified by misc-include-cleaner. I've filtered out those that break builds. Also, I'm staying away from llvm-config.h, config.h, and Compiler.h, which likely cause platform- or compiler-specific build failures.
- **Precommit tests for synchronous uwtable CFI fixup** - **[CFIFixup] Fixup CFI for split functions with synchronous uwtables** Commit https://github.com/llvm/llvm-project/commit/6e54fccede402c9ed0e8038aa258a99c5a2773e5 disables CFI fixup for functions with synchronous tables, breaking CFI for split functions. Instead, we can disable *block-level* CFI fixup for functions with synchronous tables. Unwind tables can be: - N/A (not present) - Asynchronous - Synchronous Functions without unwind tables don't need CFI fixup (since they don't care about CFI). Functions with asynchronous unwind tables must be accurate for each basic block, so full CFI fixup is necessary. Functions with synchronous unwind tables only need to be accurate for each function (specifically, the portion of a function in a given section). Disabling CFI fixup entirely for functions with synchronous uwtables may break CFI for a function split between two sections. The portion in the first section may have valid CFI, while the portion in the second section is missing a call frame. Ex: ``` (.text.hot) Foo (BB1): <Call frame information> ... BB2: ... (.text.split) BB3: ... BB4: <epilogue> ``` Even if `Foo` has a synchronous unwind table, we still need to insert call frame information into `BB3` so that unwinding the call stack from `BB3` or `BB4` works properly.
This patch adds a default constructor to BlockFlags to initialize its members to false, placing initializers close to the member declarations. Note that once C++20 is available in our codebase, we can replace the explicit default constructor with: bool Reachable : 1 = true; :
This patch was breaking tests due to inconsistent use of SmallVector. After consolidating SmallVector usages, everything should work as intended.
This reverts commit f14f19738916572322c310e84196134545c15c49, which breaks a number of build bots: - https://lab.llvm.org/buildbot/#/builders/163/builds/12726 - https://lab.llvm.org/buildbot/#/builders/144/builds/17106 - https://lab.llvm.org/buildbot/#/builders/123/builds/12855 - https://lab.llvm.org/buildbot/#/builders/133/builds/10660 - https://lab.llvm.org/buildbot/#/builders/88/builds/7482 - https://lab.llvm.org/buildbot/#/builders/180/builds/12313 - https://lab.llvm.org/buildbot/#/builders/160/builds/12316
`runOnMachineFunction` is getting long (>100 lines), and the logic for computing block info and performing block fixup can be abstracted away. Reduce nesting in the main block fixup loop and name conditions to reflect their purpose. Replace manual usage of iterators with a range-based for loop. Source: - https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code - https://llvm.org/docs/CodingStandards.html#use-range-based-for-loops-wherever-possible - https://llvm.org/docs/CodingStandards.html#don-t-evaluate-end-every-time-through-a-loop
Now that `-fbasic-block-sections=list` is enabled for Arm, functions may be split aross multiple sections, and CFI information must be handled independently for each section. On x86, this is handled in `llvm/lib/CodeGen/CFIInstrInserter.cpp`. However, this pass does not run on Arm, so we must add logic for it to `llvm/lib/CodeGen/CFIFixup.cpp`.
Identified with misc-include-cleaner.
The original patch (ac1a01f) dereferenced an end iterator, breaking some tests (e.g. https://lab.llvm.org/buildbot/#/builders/17/builds/3116). This updated patch only accesses the iterator when it's valid.
Reverts llvm/llvm-project#113328 This change breaks a number of builds (e.g https://lab.llvm.org/buildbot/#/builders/25/builds/3504), for some reason. Reverting to do some troubleshooting.