llvm-project.git/llvm/lib/BinaryFormat/AMDGPUMetadataVerifier.cpp, branch users/nico/python-2

[AMDGPU] Add dynamic LDS size implicit kernel argument to CO-v5 (#65273)

2024-01-04T13:35:12+00:00

"hidden_dynamic_lds_size" argument will be added in the reserved section
at offset 120 of the implicit argument layout.
Add "isDynamicLDSUsed" flag to AMDGPUMachineFunction to identify if a
function uses dynamic LDS.

hidden argument will be added in below cases:

- LDS global is used in the kernel.
- Kernel calls a function which uses LDS global.
- LDS pointer is passed as argument to kernel itself.

[llvm] Stop including map (NFC)

2023-12-03T19:31:38+00:00

Identified with clangd.

[AMDGPU] Add .uniform_work_group_size metadata to v5

2023-01-05T21:29:56+00:00

Amdgpu kernel with function attribute "uniform-work-group-size"="true" requires
uniform work group size (i.e. each dimension of global size is a multiple of
corresponding dimension of work group size). hipExtModuleLaunchKernel allows to
launch HIP kernel with non-uniform workgroup size, which makes it necessary for
runtime to check and enforce uniform workgroup size if kernel requires it. To
let runtime be able to enforce that, this metadata is needed to indicate that
the kernel requires uniform workgroup size.

Reviewed By: kzhuravl, arsenm

Differential Revision: https://reviews.llvm.org/D141012

[BinaryFormat] Use std::optional instead of llvm::Optional (NFC)

2022-12-17T07:20:12+00:00

This is part of an effort to migrate from llvm::Optional to
std::optional:

https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716

[AMDGPU] Add `.workgroup_processor_mode` to v5 MD

2022-12-13T15:44:52+00:00

Adds Workgroup Processor Mode (WGP) to the HSA Metadata for Code Object v5/GFX10+.
The field is already present as an asm directive and in the compute program resource register but is also needed in the MD.

Reviewed By: kzhuravl

Differential Revision: https://reviews.llvm.org/D139931

[llvm] Don't include STLForwardCompat.h (NFC)

2022-12-07T04:09:56+00:00

STLForwardCompat.h defines remove_cvref and remove_cvref_t.  These
source files use neither one of those.

[AMDGPU] Add the uses_dynamic_stack field to the kernel descriptor and the kernel metadata map

2022-07-18T04:37:13+00:00

This change introduces the dynamic stack boolean field to code-object-v3
and above under the code properties of the kernel descriptor and under
the kernel metadata map of NT_AMDGPU_METADATA. This field corresponds to
the is_dynamic_callstack field of amd_kernel_code_t.

Differential Revision: https://reviews.llvm.org/D128344

[AMDGPU][NFC]: Emit metadata for hidden_heap_v1 kernarg

2022-02-25T18:45:35+00:00

Summary:
  Emit metadata for hidden_heap_v1 kernarg

Reviewers:
  sameerds, b-sumner

Fixes:
  SWDEV-307188

Differential Revision:
  https://reviews.llvm.org/D119027

AMDGPU {NFC}: Add code object v5 support and generate metadata for implicit kernel args

2022-02-01T02:07:47+00:00

Summary:
  Add code object v5 support (deafult is still v4)
  Generate metadata for implicit kernel args for the new ABI
  Set the metadata version to be 1.2

Reviewers:
  t-tye, b-sumner, arsenm, and bcahoon

Fixes:
  SWDEV-307188, SWDEV-307189

Differential Revision:
  https://reviews.llvm.org/D118272

Cleanup headers for BinaryFormat

2022-01-26T12:44:32+00:00

A few header removal, some forward declarations. As usual, this can
break your build due to false dependencies, the most notable change are:

- "llvm/BinaryFormat/AMDGPUMetadataVerifier.h" no longer includes "llvm/BinaryFormat/MsgPackDocument.h"

The impact on generated preprocessed lines for LLVMBinaryFormat is
pretty nice:

$ clang++ -E  -Iinclude -I../llvm/include ../llvm/lib/BinaryFormat/*.cpp -std=c++14 -fno-rtti -fno-exceptions | wc -l
before this patch: 705281
after this patch: 751456

Discourse thread on the topic: https://llvm.discourse.group/t/include-what-you-use-include-cleanup