llvm-project.git/llvm/docs/CodeReview.rst, branch users/nico/python-2

[llvm][docs] Add notes on upstreaming code from downstream projects (#129743)

2025-03-12T11:17:19+00:00

For context, see:
* https://discourse.llvm.org/t/code-review-process-when-upstreaming-patches

[docs] Update docs on code-review process (#111735)

2024-11-06T07:39:43+00:00

Clarify expectations for handling new comments post-LGTM but pre-commit.

This change aims to standardize expectations when new comments are added
after a patch has received LGTM but before it has been committed.
Currently, approaches to this vary, and this update seeks to clarify
best practices.

[llvm][docs] Add Approvals section to GitHub guide (#113434)

2024-10-31T15:24:33+00:00

Based on feedback that when reading the document as a guide, it's odd
that it skips right from updating the PR to merging it.

The section is a link to the existing Code Review guide's text on the
topic.

I have updated that to mention required reviewers, which some
subprojects do use (libcxx is one) but most don't.

Also we use the words "accepted" and "approved" interchangeably, so I've
swapped one instance so it's consistent between paragraphs.

Replace documentation mentions of IRC with Discord (#114276)

2024-10-31T13:22:46+00:00

This does not touch code owners or credits files that list IRC handles,
that can be done separately if we want to make that change.

See
https://discourse.llvm.org/t/rfc-remove-irc-as-a-recommended-communication-channel/82808/3
for the RFC.

[docs] Point to Discourse for creating RFCs (#114341)

2024-10-31T12:35:57+00:00

[Policy] Replace "code owners" with "maintainers" (#107384)

2024-09-16T17:05:03+00:00

This replaces the previous Code Owners section of our developer policy
with a new section for Maintainers. It also updates most of the places
we mention "code owner" in the documentation (it does not update the
files named `Code Owners.rst` or similar because those should be updated
when the subprojects add their `Maintainers.rst` file).

The wording was taken from what was proposed in the RFC (including all
suggested amendments from folks on the thread).

Please see the RFC for more details:

https://discourse.llvm.org/t/rfc-proposing-changes-to-the-community-code-ownership-policy/80714/

[docs] Add note about "Re-request review" (#104735)

2024-08-19T16:53:03+00:00

llvm/docs: Try to fix some broken links

2024-03-09T02:19:32+00:00

I messed up the syntax here previously - let's see if this is enough to
get it working.

Document use of `skip-precommit-approval` label for non-review pull requests (#81053)

2024-02-09T00:41:04+00:00

Derived from this discussion:
https://discourse.llvm.org/t/prs-without-approvals-muddy-the-waters/76656

[llvm][Docs] Update MyFirstTypoFix doc (#79149)

2024-01-29T10:34:22+00:00

I've not tried to change the purpose or style of the doc, just edited
for clarity and removed any Phabricator related language in favour of
GitHub terms.

Where possible, I've swapped direct links to LLVM's website with RST
links to the local documents. Which should be a bit more resilient.

Also it's less confusing if you're editing multiple pages locally, you
don't accidentally end up on the live site.