llvm-project.git/lldb/test/Shell/Breakpoint/breakpoint-command.test, branch main Unnamed repository; edit this file 'description' to name the repository. [LLDB] Update breakpoint-command.test to use string instead of number. (#69796) 2023-10-22T22:42:55+00:00 cmtice cmtice@google.com 2023-10-22T22:42:55+00:00 efb0e9c0bda62ba4b1c5421baeb140016ff53c84 lldb/test/Shell/Breakpoint/breakpoint-command.test adds a python command, to be executed when a breakpoint hits, that writes out a number. It then runs, hits the breakpoint and checks that the number is present exactly once. The problem is that on some systems the test can be run in a filepath that happens to contain the number (e.g. auto-generated directory names). The number is then detected multiple times and the test fails. This patch fixes the issue by using a string instead, particularly a string with spaces, which is very unlikely to be auto-generated by any system. 
lldb/test/Shell/Breakpoint/breakpoint-command.test adds a python
command, to be executed when a breakpoint hits, that writes out a
number. It then runs, hits the breakpoint and checks that the number is
present exactly once.

The problem is that on some systems the test can be run in a filepath
that happens to contain the number (e.g. auto-generated directory
names). The number is then detected multiple times and the test fails.

This patch fixes the issue by using a string instead, particularly a
string with spaces, which is very unlikely to be auto-generated by any
system.
 Fix breakpoint-command.test when no script interpreter is compiled in. 2022-12-12T22:12:52+00:00 Mitch Phillips 31459023+hctim@users.noreply.github.com 2022-12-12T22:00:19+00:00 1b753240d50a930c12c42e2f230804db3dccde96 My local build is with -DLLVM_ENABLE_PROJECTS=lldb, but I don't compile with -DLLDB_ENABLE_PYTHON=True or -DLLDB_ENABLE_LUA=True. This results in there being no script interpreter. The test lldb/test/Shell/Breakpoint/breakpoint-command.test has an implicit dependency on a script interpreter being available. This patch makes that dependency clear. If you have a script interpreter, the test gets run, otherwise it gets skipped. This means that folks (like me) who naively use -DLLVM_ENABLE_PROJECTS=lldb can continue to run check-all without breakages. Reviewed By: JDevlieghere Differential Revision: https://reviews.llvm.org/D139463 
My local build is with -DLLVM_ENABLE_PROJECTS=lldb, but I don't compile
with -DLLDB_ENABLE_PYTHON=True or -DLLDB_ENABLE_LUA=True. This results
in there being no script interpreter.

The test lldb/test/Shell/Breakpoint/breakpoint-command.test has an
implicit dependency on a script interpreter being available.

This patch makes that dependency clear. If you have a script
interpreter, the test gets run, otherwise it gets skipped. This means
that folks (like me) who naively use -DLLVM_ENABLE_PROJECTS=lldb can
continue to run check-all without breakages.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D139463
[test] Fix a test that wasn't running 2022-10-13T03:43:46+00:00 Jordan Rupprecht rupprecht@google.com 2022-10-13T03:43:45+00:00 6eb40bf51b768672218539935f60ce55ae6ad750 The functionality is fine (we don't run the breakpoint command twice), but this test forgot to call `FileCheck` and isn't checking the same value isn't there twice.. 
The functionality is fine (we don't run the breakpoint command twice), but this test forgot to call `FileCheck` and isn't checking the same value isn't there twice..
[lldb] Don't print script output twice in HandleCommand 2021-06-08T20:57:39+00:00 Jonas Devlieghere jonas@devlieghere.com 2021-06-08T17:46:43+00:00 1a216fb15a188f9ac7de6d79267b3cfb2946f792 When executing a script command in HandleCommand(s) we currently print its output twice You can see this issue in action when adding a breakpoint command: (lldb) b main Breakpoint 1: where = main.out`main + 13 at main.cpp:2:3, address = 0x0000000100003fad (lldb) break command add 1 -o "script print(\"Hey!\")" (lldb) r Process 76041 launched: '/tmp/main.out' (x86_64) Hey! (lldb) script print("Hey!") Hey! Process 76041 stopped The issue is caused by HandleCommands using a temporary CommandReturnObject and one of the commands (`script` in this case) setting an immediate output stream. This causes the result to be printed twice: once directly to the immediate output stream and once when printing the result of HandleCommands. This patch fixes the issue by introducing a new option to suppress immediate output for temporary CommandReturnObjects. Differential revision: https://reviews.llvm.org/D103349 
When executing a script command in HandleCommand(s) we currently print
its output twice
You can see this issue in action when adding a breakpoint command:

(lldb) b main
Breakpoint 1: where = main.out`main + 13 at main.cpp:2:3, address = 0x0000000100003fad
(lldb) break command add 1 -o "script print(\"Hey!\")"
(lldb) r
Process 76041 launched: '/tmp/main.out' (x86_64)
Hey!
(lldb)  script print("Hey!")
Hey!
Process 76041 stopped

The issue is caused by HandleCommands using a temporary
CommandReturnObject and one of the commands (`script` in this case)
setting an immediate output stream. This causes the result to be printed
twice: once directly to the immediate output stream and once when
printing the result of HandleCommands.

This patch fixes the issue by introducing a new option to suppress
immediate output for temporary CommandReturnObjects.

Differential revision: https://reviews.llvm.org/D103349