llvm-project.git/lldb/test/API/python_api/watchpoint/TestWatchpointRead.py, branch main Unnamed repository; edit this file 'description' to name the repository. [lldb] WatchAddress ignores modify option (#124847) 2025-02-05T00:03:13+00:00 Ben Jackson puremourning@users.noreply.github.com 2025-02-05T00:03:13+00:00 e8d437f827144061d051ecf199d4075bef317285 The WatchAddress API includes a flag to indicate if watchpoint should be for read, modify or both. This API uses 2 booleans, but the 'modify' flag was ignored and WatchAddress unconditionally watched write (actually modify). We now only watch for modify when the modify flag is true. --- The included test fails prior to this patch and succeeds after. That is previously specifying `False` for `modify` would still stop on _write_, but after the patch correctly only stops on _read_ 
The WatchAddress API includes a flag to indicate if watchpoint should be
for read, modify or both. This API uses 2 booleans, but the 'modify'
flag was ignored and WatchAddress unconditionally watched write
(actually modify).

We now only watch for modify when the modify flag is true.

---

The included test fails prior to this patch and succeeds after. That is
previously specifying `False` for `modify` would still stop on _write_,
but after the patch correctly only stops on _read_