llvm-project.git/lldb/test/API/functionalities/stop-on-sharedlibrary-load/main.cpp, branch main Unnamed repository; edit this file 'description' to name the repository. Make the stop-on-sharedlibrary-events setting work. 2021-03-24T18:15:11+00:00 Jim Ingham jingham@apple.com 2021-03-23T01:41:12+00:00 c8faa8c2669c1867ef6ac33466f219a39d5faaa7 The StopInfoBreakpoint::PerformAction was overriding the synchronous breakpoint's ShouldStop report. Fix that and add a test. This fixes two bugs in the original submission: 1) Actually generate both dylibs by including the second one in the Makefile 2) Don't ask synchronous callbacks for their opinion on whether to stop in the async context, that info is taken care of by recording the m_should_stop on entry to PerformAction. Differential Revision: https://reviews.llvm.org/D98914 
The StopInfoBreakpoint::PerformAction was overriding the synchronous
breakpoint's ShouldStop report.  Fix that and add a test.

This fixes two bugs in the original submission:
1) Actually generate both dylibs by including the second one in the Makefile
2) Don't ask synchronous callbacks for their opinion on whether to stop
   in the async context, that info is taken care of by recording the m_should_stop
   on entry to PerformAction.

Differential Revision: https://reviews.llvm.org/D98914
Revert "Make the stop-on-sharedlibrary-events setting work." 2021-03-19T19:38:41+00:00 Jim Ingham jingham@apple.com 2021-03-19T19:38:41+00:00 9d081a7ffe5c2f9575f77bedd6cbf4385287aeec This reverts commit 9406d43138811ac4dfd0ab31434f65a649bc882e. I messed up a test, and when I got it right it was failing. The changed logic doesn't work quite right (now the async callback called at sync time is forcing us to stop. I need to be a little more careful about that. 
This reverts commit 9406d43138811ac4dfd0ab31434f65a649bc882e.

I messed up a test, and when I got it right it was failing.  The changed logic
doesn't work quite right (now the async callback called at sync time is
forcing us to stop.  I need to be a little more careful about that.
Make the stop-on-sharedlibrary-events setting work. 2021-03-19T19:02:16+00:00 Jim Ingham jingham@apple.com 2021-03-19T18:56:46+00:00 9406d43138811ac4dfd0ab31434f65a649bc882e We weren't taking into account the "m_should_stop" setting that the synchronous breakpoint callback had already set when we did PerformAction in the StopInfoBreakpoint. So we didn't obey its instructions when it told us to stop. Fixed that and added some tests both for when we just have the setting, and when we have the setting AND other breakpoints at the shared library load notification breakpoint address. Differential Revision: https://reviews.llvm.org/D98914 
We weren't taking into account the "m_should_stop" setting that the
synchronous breakpoint callback had already set when we did PerformAction
in the StopInfoBreakpoint.  So we didn't obey its instructions when it
told us to stop.  Fixed that and added some tests both for when we
just have the setting, and when we have the setting AND other breakpoints
at the shared library load notification breakpoint address.

Differential Revision: https://reviews.llvm.org/D98914