Co-authored-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
assertRegexpMatches is a deprecated alias for assertRegex and has been removed in Python 3.12. This wasn't an issue previously because we used a vendored version of the unittest module. Now that we use the built-in version this gets updated together with the Python version used to run the test suite.
This is an ongoing series of commits that are reformatting our Python code. Reformatting is done with `black` (23.1.0). If you end up having problems merging this commit because you have made changes to a python file, the best way to handle that is to run `git checkout --ours <yourfile>` and then reformat it with black. RFC: https://discourse.llvm.org/t/rfc-document-and-standardize-python-code-style Differential revision: https://reviews.llvm.org/D151460
There are two conditions for the loop exit. Either we hit LLDB_INVALID_ADDRESS or the ABI tells us we are beyond mappable memory. I made a mistake in that second part that meant if you had no ABI plugin --all would stop on the first loop and return nothing. If there's no ABI plugin we should only check for LLDB_INVALID_ADDRESS. Depends on D134029 Reviewed By: labath Differential Revision: https://reviews.llvm.org/D134030
When I wrote the initial version I forgot that a region being unmapped is not an error. There are real errors that we don't want to hide, such as the remote not supporting the qMemoryRegionInfo packet (gdbserver does not). Reviewed By: labath Differential Revision: https://reviews.llvm.org/D134029
These two tests were each of them too long when running under ASAN, so we have to skip both to get a clean ASAN bot run.
bot. This happens because they are building a long result into a Python string, and the asan checker is making that very slow. The last two tests here are both slow, but the 'test_command' is the really slow one. I'm going to start disabling just that one and see if that gets the ASAN bots clean.
As suggested in post-commit review on https://reviews.llvm.org/D129272. * Rename the test case. * Simplify the overlap check. * Correct assertion.
Previously we recorded AllocationBase as the base address of the region we get from VirtualQueryEx. However, this is the base of the allocation, which can later be split into more regions. So you got stuff like: [0x00007fff377c0000-0x00007fff377c1000) r-- PECOFF header [0x00007fff377c0000-0x00007fff37840000) r-x .text [0x00007fff377c0000-0x00007fff37870000) r-- .rdata Where all the base addresses were the same. Instead, use BaseAddress as the base of the region. So we get: [0x00007fff377c0000-0x00007fff377c1000) r-- PECOFF header [0x00007fff377c1000-0x00007fff37840000) r-x .text [0x00007fff37840000-0x00007fff37870000) r-- .rdata https://docs.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-memory_basic_information The added test checks for any overlapping regions which means if we get the base or size wrong it'll fail. This logic applies to any OS so the test isn't restricted to Windows. Reviewed By: labath Differential Revision: https://reviews.llvm.org/D129272
Eliminate boilerplate of having each test manually assign to `mydir` by calling `compute_mydir` in lldbtest.py. Differential Revision: https://reviews.llvm.org/D128077