llvm-project.git/lldb/test/API/commands/platform/basic/myshell.c, branch main Unnamed repository; edit this file 'description' to name the repository. [lldb/test] Fix TestPlatform*.py Windows failures (NFC) 2020-09-02T19:41:35+00:00 Med Ismail Bennani medismail.bennani@gmail.com 2020-09-02T19:31:09+00:00 0e86f390457a2b4dd1f2d1770db912963a36f240 This patch fixes the windows failures introduced by `addb514`: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/18671/steps/test/logs/stdio This macro, used in the test to check the platform, was missing a `_`, making the test behave like it was run from a UNIX platform. Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com> 
This patch fixes the windows failures introduced by `addb514`:
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/18671/steps/test/logs/stdio

This macro, used in the test to check the platform, was missing a `_`,
making the test behave like it was run from a UNIX platform.

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
[lldb/Target] Add custom interpreter option to `platform shell` 2020-09-02T14:36:10+00:00 Med Ismail Bennani medismail.bennani@gmail.com 2020-08-28T13:38:39+00:00 addb5148f58d710fcaba04bb2afec8006ae8ac15 This patch adds the ability to use a custom interpreter with the `platform shell` command. If the user set the `-s|--shell` option with the path to a binary, lldb passes it down to the platform's `RunShellProcess` method and set it as the shell to use in `ProcessLaunchInfo to run commands. Note that not all the Platforms support running shell commands with custom interpreters (i.e. RemoteGDBServer is only expected to use the default shell). This patch also makes some refactoring and cleanups, like swapping CString for StringRef when possible and updating `SBPlatformShellCommand` with new methods and a new constructor. rdar://67759256 Differential Revision: https://reviews.llvm.org/D86667 Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com> 
This patch adds the ability to use a custom interpreter with the
`platform shell` command. If the user set the `-s|--shell` option
with the path to a binary, lldb passes it down to the platform's
`RunShellProcess` method and set it as the shell to use in
`ProcessLaunchInfo to run commands.

Note that not all the Platforms support running shell commands with
custom interpreters (i.e. RemoteGDBServer is only expected to use the
default shell).

This patch also makes some refactoring and cleanups, like swapping
CString for StringRef when possible and updating `SBPlatformShellCommand`
with new methods and a new constructor.

rdar://67759256

Differential Revision: https://reviews.llvm.org/D86667

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>