llvm-project.git/lldb/source/Utility/RealpathPrefixes.cpp, branch users/nico/python-2 Unnamed repository; edit this file 'description' to name the repository. [lldb] Correctly fix a usage of `PATH_MAX`, and fix unit tests (#104502) 2024-08-16T00:24:39+00:00 royitaqi royitaqi@users.noreply.github.com 2024-08-16T00:24:39+00:00 26670e7fa4f032a019d23d56c6a02926e854e8af # Part 1: Correctly fix a usage of `PATH_MAX` TL;DR: Adding a typedef `lldb_private::PathSmallString` which contains a hardcoded initial size (128). # Part 2: Fix unit tests After https://github.com/llvm/llvm-project/pull/104493 fixed the build break for Windows, unit test failure showed up for Windows. The root-cause is that the `FileSpec`'s in the unit tests are not style-specific. The fix is to apply either `WindowsSpec` or `PosixSpec` specifically. 
# Part 1: Correctly fix a usage of `PATH_MAX`

TL;DR: Adding a typedef `lldb_private::PathSmallString` which contains a
hardcoded initial size (128).

# Part 2: Fix unit tests

After https://github.com/llvm/llvm-project/pull/104493 fixed the build
break for Windows, unit test failure showed up for Windows. The
root-cause is that the `FileSpec`'s in the unit tests are not
style-specific. The fix is to apply either `WindowsSpec` or `PosixSpec`
specifically.
 (lldb) Fix PATH_MAX for Windows (#104493) 2024-08-15T20:14:26+00:00 royitaqi royitaqi@users.noreply.github.com 2024-08-15T20:14:26+00:00 f377edb96abe9fd6fa458415f07b0f411e59cf24 The build break was caused by a [previous patch](https://github.com/llvm/llvm-project/pull/102223) using `PATH_MAX` which is undefined in Windows. 
The build break was caused by a [previous
patch](https://github.com/llvm/llvm-project/pull/102223) using
`PATH_MAX` which is undefined in Windows.
 [lldb] Realpath symlinks for breakpoints (#102223) 2024-08-15T18:26:24+00:00 royitaqi royitaqi@users.noreply.github.com 2024-08-15T18:26:24+00:00 47721d46187f89c12a13d07b5857496301cf5d6e Improve the chance of resolving file/line breakpoints by realpath'ing the support files before doing a second match attempt, with some conditions applied. A working [hello-world example](https://github.com/royitaqi/lldb_demos/blob/main/realpath/README.md). See [patch](https://github.com/llvm/llvm-project/pull/102223) for more info about problem/motivation, details of the feature, new settings, telemetries and tests. 
Improve the chance of resolving file/line breakpoints by realpath'ing the support files before doing a second match attempt, with some conditions applied.

A working [hello-world example](https://github.com/royitaqi/lldb_demos/blob/main/realpath/README.md).

See [patch](https://github.com/llvm/llvm-project/pull/102223) for more info about problem/motivation, details of the feature, new settings, telemetries and tests.