llvm-project.git/lldb/source/Host/common/HostNativeThreadBase.cpp, branch main

[LLDB] Applying clang-tidy modernize-use-default-member-init over LLDB

2022-03-14T20:32:03+00:00

Applied modernize-use-default-member-init clang-tidy check over LLDB.
It appears in many files we had already switched to in class member init but
never updated the constructors to reflect that. This check is already present in
the lldb/.clang-tidy config.

Differential Revision: https://reviews.llvm.org/D121481

[lldb] Modernize ThreadLauncher

2022-02-23T13:25:59+00:00

Accept a function object instead of a raw pointer. This avoids a bunch
of boilerplate typically needed to pass arguments to the thread
functions.

Differential Revision: https://reviews.llvm.org/D120321

[lldb] Rename Logging.h to LLDBLog.h and clean up includes

2022-02-03T13:47:01+00:00

Most of our code was including Log.h even though that is not where the
"lldb" log channel is defined (Log.h defines the generic logging
infrastructure). This worked because Log.h included Logging.h, even
though it should.

After the recent refactor, it became impossible the two files include
each other in this direction (the opposite inclusion is needed), so this
patch removes the workaround that was put in place and cleans up all
files to include the right thing. It also renames the file to LLDBLog to
better reflect its purpose.

[lldb] Convert "LLDB" log channel to the new API

2022-02-02T13:13:08+00:00

[lldb] Add NOLINT(modernize-use-nullptr)

2022-01-01T21:14:59+00:00

thread_result_t is defined as unsigned on Windows.

This patch prevents clang-tidy from replacing 0 with nullptr.

Revert "[lldb] Use nullptr instead of 0 or NULL (NFC)"

2022-01-01T19:15:14+00:00

This reverts commit 913457acf07be7f22d71ac41ad1076517d7f45c6.

It again broke builds on Windows:

  lldb/source/Host/common/HostNativeThreadBase.cpp(37,14): error:
  assigning to 'lldb::thread_result_t' (aka 'unsigned int') from
  incompatible type 'std::nullptr_t'

[lldb] Use nullptr instead of 0 or NULL (NFC)

2022-01-01T18:48:56+00:00

This is a re-submission of 24d240558811604354a8d6080405f6bad8d15b5c
without the hunk in HostNativeThreadBase.h, which breaks builds on
Windows.

Identified with modernize-use-nullptr.

Revert "[lldb] Use nullptr instead of 0 or NULL (NFC)"

2022-01-01T18:35:54+00:00

This reverts commit 24d240558811604354a8d6080405f6bad8d15b5c.
Breaks building on Windows:

    ../../lldb/include\lldb/Host/HostNativeThreadBase.h(49,36): error:
        cannot initialize a member subobject of type 'lldb::thread_result_t'
        (aka 'unsigned int') with an rvalue of type 'std::nullptr_t'
      lldb::thread_result_t m_result = nullptr;
                                       ^~~~~~~
    1 error generated.

[lldb] Use nullptr instead of 0 or NULL (NFC)

2022-01-01T16:54:05+00:00

Identified with modernize-use-nullptr.

[lldb] Replace default bodies of special member functions with = default;

2021-07-02T18:31:16+00:00

Replace default bodies of special member functions with = default;

$ run-clang-tidy.py -header-filter='lldb' -checks='-*,modernize-use-equals-default' -fix ,

https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html

Differential revision: https://reviews.llvm.org/D104041