llvm-project.git/lldb/source/Core/SourceManager.cpp, branch main

[lldb] Eliminate SupportFileSP nullptr derefs (#168624)

2025-11-21T00:45:11+00:00

This patch fixes and eliminates the possibility of SupportFileSP ever
being nullptr. The support file was originally treated like a value
type, but became a polymorphic type and therefore has to be stored and
passed around as a pointer.

To avoid having all the callers check the validity of the pointer, I
introduced the invariant that SupportFileSP is never null and always
default constructed. However, without enforcement at the type level,
that's fragile and indeed, we already identified two crashes where
someone accidentally broke that invariant.

This PR introduces a NonNullSharedPtr to prevent that. NonNullSharedPtr
is a smart pointer wrapper around std::shared_ptr that guarantees the
pointer is never null. If default-constructed, it creates a
default-constructed instance of the contained type. Note that I'm using
private inheritance because you shouldn't inherit from standard library
classes due to the lack of virtual destructor. So while the new
abstraction looks like a `std::shared_ptr`, it is in fact **not** a
shared pointer. Given that our destructor is trivial, we could use
public inheritance, but currently there's no need for it.

rdar://164989579

[lldb] Emit a progress event from the source manager (#165802)

2025-10-31T20:10:09+00:00

Reading a source file might take a while, for example because it's
located on a virtual file system that's fetching the data on demand.

This PR emits a progress event to convey this to the user when reading
the file exceeds a certain threshold (500ms). Although it doesn't speed
up the operation, it still greatly improves the user experience by
helping them understand what's going on.

rdar://163750392

[lldb] print a notice when `source list` paging reaches the end of th… (#137515)

2025-05-08T14:01:16+00:00

[lldb] s/GetAddressRange().GetBaseAddress()/GetAddress() (#125847)

2025-02-06T08:17:50+00:00

Three more cases where it's obvious that the code is looking for the
address of the function entry point.

[lldb] Search main function with lldb::eFunctionNameTypeFull when getting default file and line. (#113980)

2024-10-29T20:23:33+00:00

This is to work around the fact that
`SymbolFileNativePDB::FindFunctions` only support
`lldb::eFunctionNameTypeFull` and `lldb::eFunctionNameTypeMethod` now.
Since `main`'s full name is the same as base name (`main`), it's okay to
search with `lldb::eFunctionNameTypeFull` when trying to get the default
file and line. With this, `lldb/test/Shell/Driver/TestSingleQuote.test`
passes on Windows with NativePDB plugin.

[lldb] Print a warning on checksum mismatch (#107968)

2024-09-11T15:53:07+00:00

Print a warning when the debugger detects a mismatch between the MD5
checksum in the DWARF 5 line table and the file on disk. The warning is
printed only once per file.

[lldb] Avoid FileSpec indirection where we can use SupportFiles directly

2024-09-03T21:38:39+00:00

Now that more parts of LLDB know about SupportFiles, avoid going through
FileSpec (and losing the Checksum in the process). Instead, use the
SupportFile directly.

[lldb] Include checksum in source cache dump (#106773)

2024-08-30T20:16:26+00:00

This patch updates the source cache dump command to print both the
actual (on-disk) checksum and the expected (line table) checksum. To
achieve that we now read and store the on-disk checksum in the cached
object. The same information will be used in a future path to print a
warning when the checksums differ.

[lldb] Deal with SupportFiles in SourceManager (NFC) (#106740)

2024-08-30T17:58:32+00:00

To support detecting MD5 checksum mismatches, deal with SupportFiles
rather than a plain FileSpecs in the SourceManager.

[lldb] Store SupportFiles in SourceManager::File (NFC) (#106639)

2024-08-30T14:18:55+00:00

To support detecting MD5 checksum mismatches, store a SupportFile rather
than a plain FileSpec in SourceManager::File.