llvm-project.git/lldb/source/Commands/CommandObjectHelp.cpp, branch main Unnamed repository; edit this file 'description' to name the repository. Start to clean up the process of defining command arguments. (#83097) 2024-02-27T18:34:01+00:00 jimingham jingham@apple.com 2024-02-27T18:34:01+00:00 2d704f4bf2edb0f9343dac818ab4d29442be9968 Partly, there's just a lot of unnecessary boiler plate. It's also possible to define combinations of arguments that make no sense (e.g. eArgRepeatPlus followed by eArgRepeatPlain...) but these are never checked since we just push_back directly into the argument definitions. This commit is step 1 of this cleanup - do the obvious stuff. In it, all the simple homogenous argument lists and the breakpoint/watchpoint ID/Range types, are set with common functions. This is an NFC change, it just centralizes boiler plate. There's no checking yet because you can't get a single argument wrong. The end goal is that all argument definition goes through functions and m_arguments is hidden so that you can't define inconsistent argument sets. 
Partly, there's just a lot of unnecessary boiler plate. It's also
possible to define combinations of arguments that make no sense (e.g.
eArgRepeatPlus followed by eArgRepeatPlain...) but these are never
checked since we just push_back directly into the argument definitions.

This commit is step 1 of this cleanup - do the obvious stuff. In it, all
the simple homogenous argument lists and the breakpoint/watchpoint
ID/Range types, are set with common functions. This is an NFC change, it
just centralizes boiler plate. There's no checking yet because you can't
get a single argument wrong.

The end goal is that all argument definition goes through functions and
m_arguments is hidden so that you can't define inconsistent argument
sets.
 [lldb] Part 2 of 2 - Refactor `CommandObject::DoExecute(...)` return `void` (not `bool`) (#69991) 2023-10-30T20:21:00+00:00 Pete Lawrence plawrence@apple.com 2023-10-30T20:21:00+00:00 92d8a28cc665d73d9d679b8c014dd04f95d1df18 [lldb] Part 2 of 2 - Refactor `CommandObject::DoExecute(...)` to return `void` instead of ~~`bool`~~ Justifications: - The code doesn't ultimately apply the `true`/`false` return values. - The methods already pass around a `CommandReturnObject`, typically with a `result` parameter. - Each command return object already contains: - A more precise status - The error code(s) that apply to that status Part 1 refactors the `CommandObject::Execute(...)` method. - See [https://github.com/llvm/llvm-project/pull/69989](https://github.com/llvm/llvm-project/pull/69989) rdar://117378957 
[lldb] Part 2 of 2 - Refactor `CommandObject::DoExecute(...)` to return
`void` instead of ~~`bool`~~

Justifications:
- The code doesn't ultimately apply the `true`/`false` return values.
- The methods already pass around a `CommandReturnObject`, typically
with a `result` parameter.
- Each command return object already contains:
	- A more precise status
	- The error code(s) that apply to that status

Part 1 refactors the `CommandObject::Execute(...)` method.
- See
[https://github.com/llvm/llvm-project/pull/69989](https://github.com/llvm/llvm-project/pull/69989)

rdar://117378957
 Move from llvm::makeArrayRef to ArrayRef deduction guides - last part 2023-01-10T10:47:43+00:00 serge-sans-paille sguelton@mozilla.com 2023-01-09T17:11:07+00:00 984b800a036fc61ccb129a8da7592af9cadc94dd This is a follow-up to https://reviews.llvm.org/D140896, split into several parts as it touches a lot of files. Differential Revision: https://reviews.llvm.org/D141298 
This is a follow-up to https://reviews.llvm.org/D140896, split into
several parts as it touches a lot of files.

Differential Revision: https://reviews.llvm.org/D141298
Revert "[lldb] Remove redundant .c_str() and .get() calls" 2022-12-19T08:52:10+00:00 Muhammad Omair Javaid omair.javaid@linaro.org 2022-12-19T08:50:31+00:00 58e9cc13e24f668a33abdae201d59a02e10c22c0 This reverts commit fbaf48be0ff6fb24b9aa8fe9c2284fe88a8798dd. This has broken all LLDB buildbots: https://lab.llvm.org/buildbot/#/builders/68/builds/44990 https://lab.llvm.org/buildbot/#/builders/96/builds/33160 
This reverts commit fbaf48be0ff6fb24b9aa8fe9c2284fe88a8798dd.

This has broken all LLDB buildbots:
https://lab.llvm.org/buildbot/#/builders/68/builds/44990
https://lab.llvm.org/buildbot/#/builders/96/builds/33160
[lldb] Remove redundant .c_str() and .get() calls 2022-12-18T01:15:25+00:00 Fangrui Song i@maskray.me 2022-12-18T01:15:25+00:00 fbaf48be0ff6fb24b9aa8fe9c2284fe88a8798dd Removing .c_str() has a semantics difference, but the use scenarios likely do not matter as we don't have NUL in the strings. 
Removing .c_str() has a semantics difference, but the use scenarios
likely do not matter as we don't have NUL in the strings.
[lldb] Refactor command option enum values (NFC) 2022-07-15T04:18:07+00:00 Jonas Devlieghere jonas@devlieghere.com 2022-07-14T03:11:37+00:00 7ced9fff95473c1794b51a3cfd099b4fea3d1a58 Refactor the command option enum values and the command argument table to connect the two. This has two benefits: - We guarantee that two options that use the same argument type have the same accepted values. - We can print the enum values and their description in the help output. (D129707) Differential revision: https://reviews.llvm.org/D129703 
Refactor the command option enum values and the command argument table
to connect the two. This has two benefits:

 - We guarantee that two options that use the same argument type have
   the same accepted values.
 - We can print the enum values and their description in the help
   output. (D129707)

Differential revision: https://reviews.llvm.org/D129703
[Commands] Remove redundant member initialization (NFC) 2022-01-23T19:07:14+00:00 Kazu Hirata kazu@google.com 2022-01-23T19:07:14+00:00 abb0ed44957cb4ba1bc94d19202860f10369cea1 Identified with readability-redundant-member-init. 
Identified with readability-redundant-member-init.
Add a "command container" hierarchy to allow users to add container nodes. 2021-10-18T22:29:24+00:00 Jim Ingham jingham@apple.com 2021-10-12T17:55:24+00:00 c5011aed9c297d6ddd8ee4f77453b215aa27554a The point is to allow users with a related set of script based commands to organize their commands in a hierarchy in the command set, rather than having to have only top-level commands. Differential Revision: https://reviews.llvm.org/D110298 
The point is to allow users with a related set of script based commands
to organize their commands in a hierarchy in the command set, rather than
having to have only top-level commands.

Differential Revision: https://reviews.llvm.org/D110298
[lldb] Remove redundant calls to set eReturnStatusFailed 2021-06-17T13:39:35+00:00 David Spickett david.spickett@linaro.org 2021-06-17T11:32:23+00:00 eaf60a4411f79a1addfa6c5d8ddf4b47e082881e This is part 2, covering the commands source. Some uses remain where it's tricky to see what the logic is or they are not used with AppendError. Reviewed By: teemperor Differential Revision: https://reviews.llvm.org/D104448 
This is part 2, covering the commands source.

Some uses remain where it's tricky to see what the
logic is or they are not used with AppendError.

Reviewed By: teemperor

Differential Revision: https://reviews.llvm.org/D104448
Make llvm::StringRef to std::string conversions explicit. 2020-01-28T22:25:25+00:00 Benjamin Kramer benny.kra@googlemail.com 2020-01-28T19:23:46+00:00 adcd02683856c30ba6f349279509acecd90063df This is how it should've been and brings it more in line with std::string_view. There should be no functional change here. This is mostly mechanical from a custom clang-tidy check, with a lot of manual fixups. It uncovers a lot of minor inefficiencies. This doesn't actually modify StringRef yet, I'll do that in a follow-up. 
This is how it should've been and brings it more in line with
std::string_view. There should be no functional change here.

This is mostly mechanical from a custom clang-tidy check, with a lot of
manual fixups. It uncovers a lot of minor inefficiencies.

This doesn't actually modify StringRef yet, I'll do that in a follow-up.