llvm-project.git/compiler-rt/test/fuzzer/BigFileCopy.cpp, branch main Unnamed repository; edit this file 'description' to name the repository. [fuzzer] Use puts() rather than printf() in CopyFileToErr() 2023-03-28T21:19:35+00:00 Roy Sundahl rsundahl@apple.com 2023-03-16T01:56:11+00:00 90b4d1bcb20180c591385131b12fa90d2e4860b1 CopyFileToErr() uses Printf("%s", ...) which fails with a negative size on files >2Gb (Its path is through var-args wrappers to an unnecessary "%s" expansion and subject to int overflows) Using puts() in place of printf() bypasses this path and writes the string directly to stderr. This avoids the present loss of data when a crashed worker has generated >2Gb of output. rdar://99384640 Reviewed By: yln, rsundahl Differential Revision: https://reviews.llvm.org/D146189 
CopyFileToErr() uses Printf("%s", ...) which fails with a negative size on
files >2Gb (Its path is through var-args wrappers to an unnecessary "%s"
expansion and subject to int overflows) Using puts() in place of printf()
bypasses this path and writes the string directly to stderr. This avoids the
present loss of data when a crashed worker has generated >2Gb of output.

rdar://99384640

Reviewed By: yln, rsundahl

Differential Revision: https://reviews.llvm.org/D146189
Revert "[fuzzer] Use puts() rather than printf() in CopyFileToErr()" 2023-03-17T23:00:56+00:00 Matthew Voss matthew.voss@sony.com 2023-03-17T22:57:07+00:00 d02ff3d578312f4924b7d3926666ea454239bf25 This reverts commit 03aa02adb03c928ae4ec9d139b303348f81861c9. Reverting due to bot failures: https://lab.llvm.org/buildbot/#/builders/247/builds/2653 
This reverts commit 03aa02adb03c928ae4ec9d139b303348f81861c9.

Reverting due to bot failures:
https://lab.llvm.org/buildbot/#/builders/247/builds/2653
[fuzzer] Use puts() rather than printf() in CopyFileToErr() 2023-03-17T16:08:40+00:00 Roy Sundahl rsundahl@apple.com 2023-03-16T01:56:11+00:00 03aa02adb03c928ae4ec9d139b303348f81861c9 CopyFileToErr() uses Printf("%s", ...) which fails with a negative size on files >2Gb (Its path is through var-args wrappers to an unnecessary "%s" expansion and subject to int overflows) Using puts() in place of printf() bypasses this path and writes the string directly to stderr. This avoids the present loss of data when a crashed worker has generated >2Gb of output. rdar://99384640 Reviewed By: yln Differential Revision: https://reviews.llvm.org/D146189 
CopyFileToErr() uses Printf("%s", ...) which fails with a negative size on
files >2Gb (Its path is through var-args wrappers to an unnecessary "%s"
expansion and subject to int overflows) Using puts() in place of printf()
bypasses this path and writes the string directly to stderr. This avoids the
present loss of data when a crashed worker has generated >2Gb of output.

rdar://99384640

Reviewed By: yln

Differential Revision: https://reviews.llvm.org/D146189