llvm-project.git/clang/test/CodeGenSYCL/unique_stable_name_windows_diff.cpp, branch main Unnamed repository; edit this file 'description' to name the repository. [NFC][clang] Fix CodeGenSYCL::unique_stable_name_windows_diff test (#146854) 2025-07-08T07:33:19+00:00 Mariya Podchishchaeva mariya.podchishchaeva@intel.com 2025-07-08T07:33:19+00:00 6d14483912807072d35714538ae41123686d7abd The test checks x86 target in fsycl-is-device mode. x86 is not a valid offloading target and IMO test meant to check fsycl-is-host mode to make sure host invocations of __builtin_sycl_unique_stable_name work correctly. This also switches the test to use sycl_entry_point attribute instead of sycl_kernel because the intention for the future SYCL changes is to use sycl_entry_point and eventually remove sycl_kernel attribute when sycl_entry_point supports enough SYCL cases. Fixes https://github.com/llvm/llvm-project/issues/146566 --------- Co-authored-by: Tom Honermann <tom@honermann.net> Co-authored-by: Victor Lomuller <victor@codeplay.com> 
The test checks x86 target in fsycl-is-device mode. x86 is not a valid
offloading target and IMO test meant to check fsycl-is-host mode to make
sure host invocations of __builtin_sycl_unique_stable_name work
correctly. This also switches the test to use sycl_entry_point attribute
instead of sycl_kernel because the intention for the future SYCL changes
is to use sycl_entry_point and eventually remove sycl_kernel attribute
when sycl_entry_point supports enough SYCL cases.

Fixes https://github.com/llvm/llvm-project/issues/146566

---------

Co-authored-by: Tom Honermann <tom@honermann.net>
Co-authored-by: Victor Lomuller <victor@codeplay.com>
 [NFC] Simple typo correction. (#114548) 2024-11-01T16:40:57+00:00 c8ef c8ef@outlook.com 2024-11-01T16:40:57+00:00 b57b3f64253a57831a5e5f4e6557d2f9cb01d017 






Fix incorrect cast in VisitSYCLUniqueStableNameExpr
2022-11-19T11:43:17+00:00

Alex Richardson
alexrichardson@google.com

2022-11-18T21:15:01+00:00

0745b0c0354a0c8e1fefb68a3876d15db6c2e27a

Clang language-level address spaces and LLVM pointer address spaces are
not the same thing (even though they will both have a numeric value of
zero in many cases). LangAS is a enum class to avoid implicit conversions,
but eba69b59d1a30dead07da2c279c8ecfd2b62ba9f avoided the compiler error by
adding a `static_cast<>`. While touching this code, simplify it by using
CreatePointerBitCastOrAddrSpaceCast() which is already a no-op if the types
match.

This changes the code generation for spir64 to place the globals in
the sycl_global addreds space, which maps to `addrspace(1)`.

Reviewed By: bader

Differential Revision: https://reviews.llvm.org/D138284





Clang language-level address spaces and LLVM pointer address spaces are
not the same thing (even though they will both have a numeric value of
zero in many cases). LangAS is a enum class to avoid implicit conversions,
but eba69b59d1a30dead07da2c279c8ecfd2b62ba9f avoided the compiler error by
adding a `static_cast<>`. While touching this code, simplify it by using
CreatePointerBitCastOrAddrSpaceCast() which is already a no-op if the types
match.

This changes the code generation for spir64 to place the globals in
the sycl_global addreds space, which maps to `addrspace(1)`.

Reviewed By: bader

Differential Revision: https://reviews.llvm.org/D138284







Change __builtin_sycl_unique_stable_name to just use an Itanium mangling
2021-09-28T13:41:03+00:00

Erich Keane
erich.keane@intel.com

2021-09-22T19:24:53+00:00

9324cc2ca951fe5fe11c85470cb08e699c59499c

After significant problems in our downstream with the previous
implementation, the SYCL standard has opted to make using macros/etc to
change kernel-naming-lambdas in any way UB (even passively). As a
result, we are able to just emit the itanium mangling.

However, this DOES require a little work in the CXXABI, as the microsoft
and itanium mangler use different numbering schemes for lambdas.  This
patch adds a pair of mangling contexts that use the normal 'itanium'
mangling strategy to fill in the "DeviceManglingNumber" used previously
by CUDA.

Differential Revision: https://reviews.llvm.org/D110281





After significant problems in our downstream with the previous
implementation, the SYCL standard has opted to make using macros/etc to
change kernel-naming-lambdas in any way UB (even passively). As a
result, we are able to just emit the itanium mangling.

However, this DOES require a little work in the CXXABI, as the microsoft
and itanium mangler use different numbering schemes for lambdas.  This
patch adds a pair of mangling contexts that use the normal 'itanium'
mangling strategy to fill in the "DeviceManglingNumber" used previously
by CUDA.

Differential Revision: https://reviews.llvm.org/D110281







[SYCL] Fix __builtin_sycl_unique_stable_name to work on windows/spir
2021-06-02T20:16:14+00:00

Erich Keane
erich.keane@intel.com

2021-06-02T19:50:52+00:00

d8e0ae9a76a62bdc6117630d59bf9967ac9bb4ea

In the case where the device is an itanium target, and the host is a
windows target, we were getting the names wrong, since in the itanium
case we filter by lambda-signature.

The fix is to always filter by the signature rather than just on
non-windows builds. I considered doing the reverse (that is, checking
the aux-triple), but doing so would result in duplicate lambda mangling
numbers (from linux reusing the same number for different signatures).





In the case where the device is an itanium target, and the host is a
windows target, we were getting the names wrong, since in the itanium
case we filter by lambda-signature.

The fix is to always filter by the signature rather than just on
non-windows builds. I considered doing the reverse (that is, checking
the aux-triple), but doing so would result in duplicate lambda mangling
numbers (from linux reusing the same number for different signatures).