Following on the Sema changes, this does the lowering for all of the operators that can be done as a compound operator. Lowering is very simply looping through the objects based on array/compound/etc, and doing a call to the operation.
This reverts commit https://github.com/llvm/llvm-project/commit/8d9aecce064776a9a890f3c898165f99e8eaa13e. Additionally, this refactors how we're doing the AST storage to put it all in the trailing storage, which will hopefully prevent it from leaking. The problem was that the AST doesn't call destructors on things in ASTContext storage, so we weren't actually able to delete the combiner SmallVector (which I should have known...). This patch instead moves all of that SmallVector data into trailing storage, which shouldn't have the same problem with leaking as before.
This reverts commit 09d9f508a44a30a323bd06fe14a5962b2cf95866. This reverts commit 1d89844bd4152af93f5dbf475996d6bd66c74bd5. Even after my fix, it seems that this still fails ASAN/the sanitizer build. I'm going to revert everything and see if I can get this to repro locally.
…(… (#162920) This reverts commit 8d9aecce064776a9a890f3c898165f99e8eaa13e. That was reverted because of an ASAN failure that I believe this fixes. The std::uninitialized_copy of an array of a type that contained a llvm::vector using operator= instead of the copy constructor, so it made ASan think it was overwriting existing data? However, it also probably would have tried to do some sort of deallocation if had the 'right' amount of wrong data. So this version switches over to using placement-new instead.
…#162740)" This reverts commit 6010df0402e2f5cca0ded446a70492dedc43ab7e. This apparently fails some sanitizer test as reported here: https://github.com/llvm/llvm-project/pull/162740 It isn't really clear where this happens, but reverting as it is a friday, and I have no idea if I'll be able to repro this anytime soon, let alone fix it.
As a followup to the previous AST changes, the next step is to generate the proper expressions in Sema. This patch does so for +,*,&,|,^ by modeling them as compound operators. This also causes the legality of some expressions to change, as these have to be legal operations, but were previously unchecked, so there are some test changes. This does not yet generate any CIR, that will happen in the next patch.
This mirrors changes from https://github.com/llvm/clangir/pull/1933
Just like with private, the lowering for these bounds are all pretty trivial. This patch enables them for reduction, which has everything in common except the init pattern, but that is handled/managed by Sema. This also adds sufficient testing to spot-check the allocation/initialization/destruction/etc.
This mirrors incubator changes from https://github.com/llvm/clangir/pull/1922
It was noticed on a previous patch that I could have emitted recipes in lexical order instead of reverse order, which would improve the readability of a lot of tests. This patch implements that, and changes all of the required test.