llvm-project.git/clang/lib/CodeGen/ObjectFilePCHContainerWriter.cpp, branch users/nico/python-1 Unnamed repository; edit this file 'description' to name the repository. [IR] Store Triple in Module (NFC) (#129868) 2025-03-06T09:27:47+00:00 Nikita Popov npopov@redhat.com 2025-03-06T09:27:47+00:00 979c275097a642e9b96c6b0a12f013c831af3a6e The module currently stores the target triple as a string. This means that any code that wants to actually use the triple first has to instantiate a Triple, which is somewhat expensive. The change in #121652 caused a moderate compile-time regression due to this. While it would be easy enough to work around, I think that architecturally, it makes more sense to store the parsed Triple in the module, so that it can always be directly queried. For this change, I've opted not to add any magic conversions between std::string and Triple for backwards-compatibilty purses, and instead write out needed Triple()s or str()s explicitly. This is because I think a decent number of them should be changed to work on Triple as well, to avoid unnecessary conversions back and forth. The only interesting part in this patch is that the default triple is Triple("") instead of Triple() to preserve existing behavior. The former defaults to using the ELF object format instead of unknown object format. We should fix that as well. 
The module currently stores the target triple as a string. This means
that any code that wants to actually use the triple first has to
instantiate a Triple, which is somewhat expensive. The change in #121652
caused a moderate compile-time regression due to this. While it would be
easy enough to work around, I think that architecturally, it makes more
sense to store the parsed Triple in the module, so that it can always be
directly queried.

For this change, I've opted not to add any magic conversions between
std::string and Triple for backwards-compatibilty purses, and instead
write out needed Triple()s or str()s explicitly. This is because I think
a decent number of them should be changed to work on Triple as well, to
avoid unnecessary conversions back and forth.

The only interesting part in this patch is that the default triple is
Triple("") instead of Triple() to preserve existing behavior. The former
defaults to using the ELF object format instead of unknown object
format. We should fix that as well.
 [clang][modules] Partially revert 48d0eb518 to fix -gmodules output (#124003) 2025-01-23T00:24:56+00:00 Ben Langmuir blangmuir@apple.com 2025-01-23T00:24:56+00:00 9fbf5cfebcd770fbe0e453f36ee7c74809339f18 With the changes in 48d0eb518, the CodeGenOptions used to emit .pcm files with -fmodule-format=obj (-gmodules) were the ones from the original invocation, rather than the ones specifically crafted for outputting the pcm. This was causing the pcm to be written with only the debug info and without the __clangast section in some cases (e.g. -O2). This unforunately was not covered by existing tests, because compiling and loading a module within a single compilation load the ast content from the in-memory module cache rather than reading it from the pcm file that was written. This broke bootstrapping a build of clang with modules enabled on Darwin. rdar://143418834 
With the changes in 48d0eb518, the CodeGenOptions used to emit .pcm
files with -fmodule-format=obj (-gmodules) were the ones from the
original invocation, rather than the ones specifically crafted for
outputting the pcm. This was causing the pcm to be written with only the
debug info and without the __clangast section in some cases (e.g. -O2).
This unforunately was not covered by existing tests, because compiling
and loading a module within a single compilation load the ast content
from the in-memory module cache rather than reading it from the pcm file
that was written. This broke bootstrapping a build of clang with modules
enabled on Darwin.

rdar://143418834
 [clang][PCH] Don't try to create standalone debug-info for types marked nodebug (#123253) 2025-01-17T09:35:02+00:00 Michael Buch michaelbuch12@gmail.com 2025-01-17T09:35:02+00:00 30e276d06d3176f145151cea96ab01af0c3e842a Fixes one of the crashes uncovered by https://github.com/llvm/llvm-project/pull/118710 `getOrCreateStandaloneType` asserts that a `DIType` was created for the requested type. If the `Decl` was marked `nodebug`, however, we can't generate debug-info for it, so we would previously trigger the assert. For now keep the assertion around and check the `nodebug` at the callsite. 
Fixes one of the crashes uncovered by
https://github.com/llvm/llvm-project/pull/118710

`getOrCreateStandaloneType` asserts that a `DIType` was created for the
requested type. If the `Decl` was marked `nodebug`, however, we can't
generate debug-info for it, so we would previously trigger the assert.
For now keep the assertion around and check the `nodebug` at the
callsite.
 [CodeGen] Simplify EmitAssemblyHelper and emitBackendOutput 2025-01-10T05:23:52+00:00 Fangrui Song i@maskray.me 2025-01-10T05:23:52+00:00 48d0eb5181065a3d086de2e30f5c619fe407e4ce Prepare for -ftime-report change (#122225). 
Prepare for -ftime-report change (#122225).
[CodeGen] Remove unused includes (NFC) (#116459) 2024-11-16T15:37:13+00:00 Kazu Hirata kazu@google.com 2024-11-16T15:37:13+00:00 e8a6624325e0c628ec23e5f124f1d2002f138dd5 Identified with misc-include-cleaner. 
Identified with misc-include-cleaner.
 [clang] Split ObjectFilePCHContainerReader from ObjectFilePCHContainerWriter (#99599) 2024-07-23T15:55:31+00:00 Chuanqi Xu yedeng.yd@linux.alibaba.com 2024-07-23T15:55:31+00:00 d64eccf4335e99360132b724d060d704892fbb02 Close https://github.com/llvm/llvm-project/issues/99479 See https://github.com/llvm/llvm-project/issues/99479 for details 
Close https://github.com/llvm/llvm-project/issues/99479

See https://github.com/llvm/llvm-project/issues/99479 for details