llvm-project.git/bolt/lib/Core/BinaryFunctionProfile.cpp, branch main

[BOLT][NFC] Disambiguate sample as basic sample (#139350)

2025-05-13T00:15:16+00:00

Sample is a general term covering both basic (IP) and branch (LBR)
profiles. Find and replace ambiguous uses of sample in a basic sample
sense.

Rename `RawBranchCount` into `RawSampleCount` reflecting its use for
both kinds of profile.

Rename `PF_LBR` profile type as `PF_BRANCH` reflecting non-LBR based
branch profiles (non-brstack SPE, synthesized brstack ETM/PT).

Follow-up to #137644.

Test Plan: NFC

[BOLT] Improve BinaryFunction::inferFallThroughCounts() (#105450)

2024-08-21T04:35:07+00:00

This PR improves how basic block execution count is updated when using
the BOLT option `-infer-fall-throughs`. Previously, if a 0-count
fall-through edge is assigned a positive inferred count N, then the
successor block's execution count will be incremented by N. Since the
successor's execution count is calculated using information besides
inflow sum (such as outflow sum), it likely is already correct, and
incrementing it by an additional N would be wrong. This PR improves how
the successor's execution count is updated by using the max over its
current count and N.

[BOLT] Fix warnings

2023-12-11T20:55:29+00:00

This patch fixes:

  bolt/lib/Core/BinaryFunctionProfile.cpp:222:10: error: variable
  'BBMergeSI' set but not used [-Werror,-Wunused-but-set-variable]

  bolt/lib/Passes/VeneerElimination.cpp:67:12: error: variable
  'VeneerCallers' set but not used [-Werror,-Wunused-but-set-variable]

[bolt] Remove redundaunt control-flow statements (NFC)

2022-07-30T17:35:49+00:00

Identified with readability-redundant-control-flow.

[BOLT][NFC] Add aliases for ICP flags

2022-06-27T17:29:26+00:00

- `indirect-call-promotion` -> `icp`
- `indirect-call-promotion-mispredict-threshold` -> `icp-mp-threshold`
- `indirect-call-promotion-use-mispredicts` -> `icp-use-mp`
- `indirect-call-promotion-topn` -> `icp-topn`
- `indirect-call-promotion-calls-topn` -> `icp-calls-topn`
- `indirect-call-promotion-jump-tables-topn` -> `icp-jt-topn`
- `icp-jump-table-targets` -> `icp-jt-targets`

This also fixes an inconsistency in ICP flag names that some start with
`indirect-call-promotion` while others start with `icp`.

Reviewed By: rafauler

Differential Revision: https://reviews.llvm.org/D128375

[bolt] Remove unneeded cl::ZeroOrMore for cl::opt options

2022-06-05T20:29:49+00:00

[BOLT][NFC] Make ICP options naming uniform

2022-05-04T02:32:45+00:00

Rename `opts::IndirectCallPromotion*` to `opts::ICP*`, making option naming
uniform and easier to follow.

Reviewed By: rafauler

Differential Revision: https://reviews.llvm.org/D124879

[BOLTCore] [NFC] Fix braces usages according to LLVM

2021-12-20T19:07:46+00:00

Summary:
Fix according to Coding Standards doc, section Don't Use
Braces on Simple Single-Statement Bodies of if/else/loop Statements.
This set of changes applies to lib Core only.

(cherry picked from FBD33240028)

[BOLT][NFC] Fix file-description comments

2021-12-21T18:21:41+00:00

Summary: Fix comments at the start of source files.

(cherry picked from FBD33274597)

[BOLT] Fix profile and tests for nop-removal pass

2021-12-19T01:05:00+00:00

Summary:
Since nops are now removed in a separate pass, the profile is consumed
on a CFG with nops. If previously a profile was generated without nops,
the offsets in the profile could be different if branches included nops
either as a source or a destination.

This diff adjust offsets to make the profile reading backwards
compatible.

(cherry picked from FBD33231254)