glibc.git/support, branch master

support: Exit on consistency check failure in resolv_response_add_name

2025-11-07T07:50:44+00:00

Using TEST_VERIFY (crname_target != crname) instructs some analysis
tools that crname_target == crname might hold.  Under this assumption,
they report a use-after-free for crname_target->offset below, caused
by the previous free (crname).

Reviewed-by: Collin Funk

support: Fix FILE * leak in check_for_unshare_hints in test-container

2025-11-06T15:27:51+00:00

The file opened via fopen is never closed.

Fix incorrect setrlimit return value checks in tests

2025-10-29T01:51:51+00:00

The setrlimit(2) function returns 0 on success and -1 on error, but
several test files were incorrectly checking for a return value of 1
to detect errors.  This means the error checks would never trigger,
causing tests to continue silently even when setrlimit() failed.

This commit fixes the error checks in five files to correctly test
for -1, matching both the documented behavior and the pattern used
correctly in other parts of the codebase.

Signed-off-by: Osama Abdelkader 
Reviewed-by: Collin Funk

support: Handle clang support/dtotimespec.c on dtotimespec

2025-10-21T12:26:04+00:00

clang issues:

dtotimespec.c:31:25: error: implicit conversion from 'time_t' (aka
'long') to 'double' changes value from 9223372036854775807 to
9223372036854775808 [-Werror,-Wimplicit-const-int-float-conversion]
  else if (sec >= 1.0 + TYPE_MAXIMUM (time_t))
                      ~ ^~~~~~~~~~~~~~~~~~~~~
../include/intprops.h:57:4: note: expanded from macro 'TYPE_MAXIMUM'
  ((t) (! TYPE_SIGNED (t)
\
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

So explicit cast it to double.

Reviewed-by: Sam James

support: Use CHAR_MAX as maximum value

2025-10-21T12:24:29+00:00

On ABIs with defined 'char' was unsigned type, clang fails to build
support_process_state.c with:

  support_process_state.c:70:21: error: result of comparison of constant  -1 with expression of type 'char' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
     70 |       if (cur_state == -1)
        |           ~~~~~~~~~ ^  ~~
  1 error generated.

Reviewed-by: Sam James

support: Add support_accept_oom to heuristically support OOM errors

2025-09-18T17:11:38+00:00

Some tests may trigger the kernel OOM handler under conditions
which are difficult to predict (depending on available RAM and
swap space).  If we can determine specific regions which might
do this and this does not contradict the test object, the
functions support_accept_oom (true) and support_accept_oom (false)
can be called at the start and end, and the test driver will
ignore SIGKILL signals.

Reviewed-by: Carlos O'Donell

support: fix build failure due to lack of stdbool.h

2025-09-17T12:02:01+00:00

On some targets using bool in support/check_mem_access.h resulted
in build error due to stdbool.h not being included, fix this.

See 9be489d77867dd2444ecc044a5f3049d1751ee85 for details.

Reported-by: Joseph Myers 
Reviewed-by: Adhemerval Zanella

support: add check_mem_access function

2025-09-15T08:47:41+00:00

Add check_mem_access(addr) function to check if memory at addr can
be written or read returning false if memory is not accessible.

This function changes signal handler for SIGSEGV and SIGBUS signals
when it is called first, and it is not thread-safe.

Co-authored-by: Adhemerval Zanella Netto 
Reviewed-by: Adhemerval Zanella

support: Implement 'xfmemopen' for seamless 'fmemopen' use

2025-09-05T10:53:31+00:00

Add 'xfmemopen' wrapper for seamless 'fmemopen' use in tests, following
'xfopen', 'xfclose', etc., and providing a standardized error reporting
facility.

Reviewed-by: Florian Weimer

Tests: Create files with mode 0666, not 0777 (bug 33171)

2025-09-01T13:12:28+00:00

Mode 0777 should be used for directories only because it results
in executable entries (after typical umasks are applied).

Reviewed-by: Arjun Shankar