glibc.git/string/test-strcmp.c, branch zack/remove-libcrypt

Fix all the remaining misspellings -- BZ 25337

2023-06-02T01:39:48+00:00

string: Hook up the default implementation on test-strcmp

2023-02-06T19:19:35+00:00

Reviewed-by: Richard Henderson

Update copyright dates with scripts/update-copyrights

2023-01-06T21:14:39+00:00

tests/string: Drop simple/stupid/builtin tests

2022-04-06T15:23:24+00:00

In most cases the simple/stupid/builtin functions were in there to
benchmark optimized implementations against.  Only in some cases the
functions are used to check expected results.

Remove these tests from IMPL() and only keep them in wherever they're
used for a specific purpose, e.g. to generate expected results.

This improves timing of `make subdirs=string` by over a minute and a
half (over 15%) on a Whiskey Lake laptop.

Signed-off-by: Siddhesh Poyarekar 
Reviewed-by: Noah Goldstein

string: Expand page cross test cases in test-strcmp.c

2022-03-25T16:46:13+00:00

Test cases for when both `s1` and `s2` are near the end of a page
where previously missing.
Reviewed-by: H.J. Lu

String: Ensure 'MIN_PAGE_SIZE' is multiple of 'getpagesize'

2022-02-11T10:06:27+00:00

When 'TEST_LEN' was defined as (4096 * 3) the allocation size Would
not be a multiple of system page size if system page size > 4096.

string: Improve coverage in test-strcmp.c and test-strncmp.c

2022-02-03T22:41:36+00:00

Add additional test cases for small / medium sizes.

Add tests in test-strncmp.c where `n` is near ULONG_MAX or LONG_MIN to
test for overflow bugs in length handling.

Signed-off-by: Noah Goldstein

string/test-str*cmp: remove stupid_[strcmp, strncmp, wcscmp, wcsncmp].

2022-02-03T22:41:34+00:00

These implementations just add to test duration. Since we have
simple_* implementations we already have a safe reference
implementation.

Signed-off-by: Noah Goldstein

Update copyright dates with scripts/update-copyrights

2022-01-01T19:40:24+00:00

I used these shell commands:

../glibc/scripts/update-copyrights $PWD/../gnulib/build-aux/update-copyright
(cd ../glibc && git commit -am"[this commit message]")

and then ignored the output, which consisted lines saying "FOO: warning:
copyright statement not found" for each of 7061 files FOO.

I then removed trailing white space from math/tgmath.h,
support/tst-support-open-dev-null-range.c, and
sysdeps/x86_64/multiarch/strlen-vec.S, to work around the following
obscure pre-commit check failure diagnostics from Savannah.  I don't
know why I run into these diagnostics whereas others evidently do not.

remote: *** 912-#endif
remote: *** 913:
remote: *** 914-
remote: *** error: lines with trailing whitespace found
...
remote: *** error: sysdeps/unix/sysv/linux/statx_cp.c: trailing lines

x86-64: Use notl in EVEX strcmp [BZ #28646]

2021-12-04T05:14:11+00:00

Must use notl %edi here as lower bits are for CHAR comparisons
potentially out of range thus can be 0 without indicating mismatch.
This fixes BZ #28646.

Co-Authored-By: H.J. Lu