glibc.git/debug/tst-sprintf-fortify-rdonly.c, branch master Unnamed repository; edit this file 'description' to name the repository. Fix incorrect setrlimit return value checks in tests 2025-10-29T01:51:51+00:00 Osama Abdelkader osama.abdelkader@gmail.com 2025-10-28T20:58:35+00:00 96073e9f34acd58dd419584218351e86ba8cf6d8 The setrlimit(2) function returns 0 on success and -1 on error, but several test files were incorrectly checking for a return value of 1 to detect errors. This means the error checks would never trigger, causing tests to continue silently even when setrlimit() failed. This commit fixes the error checks in five files to correctly test for -1, matching both the documented behavior and the pattern used correctly in other parts of the codebase. Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com> Reviewed-by: Collin Funk <collin.funk1@gmail.com> 
The setrlimit(2) function returns 0 on success and -1 on error, but
several test files were incorrectly checking for a return value of 1
to detect errors.  This means the error checks would never trigger,
causing tests to continue silently even when setrlimit() failed.

This commit fixes the error checks in five files to correctly test
for -1, matching both the documented behavior and the pattern used
correctly in other parts of the codebase.

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Reviewed-by: Collin Funk <collin.funk1@gmail.com>
debug: Improve '%n' fortify detection (BZ 30932) 2025-03-21T18:46:48+00:00 Adhemerval Zanella adhemerval.zanella@linaro.org 2025-03-14T19:09:57+00:00 ed6a68bac7cd056abda9008019c71b167f0362dc The 7bb8045ec0 path made the '%n' fortify check ignore EMFILE errors while trying to open /proc/self/maps, and this added a security issue where EMFILE can be attacker-controlled thus making it ineffective for some cases. The EMFILE failure is reinstated but with a different error message. Also, to improve the false positive of the hardening for the cases where no new files can be opened, the _dl_readonly_area now uses _dl_find_object to check if the memory area is within a writable ELF segment. The procfs method is still used as fallback. Checked on x86_64-linux-gnu and i686-linux-gnu. Reviewed-by: Arjun Shankar <arjun@redhat.com> 
The 7bb8045ec0 path made the '%n' fortify check ignore EMFILE errors
while trying to open /proc/self/maps, and this added a security
issue where EMFILE can be attacker-controlled thus making it
ineffective for some cases.

The EMFILE failure is reinstated but with a different error
message.  Also, to improve the false positive of the hardening for
the cases where no new files can be opened, the
_dl_readonly_area now uses  _dl_find_object to check if the
memory area is within a writable ELF segment.  The procfs method is
still used as fallback.

Checked on x86_64-linux-gnu and i686-linux-gnu.
Reviewed-by: Arjun Shankar <arjun@redhat.com>
Update copyright dates with scripts/update-copyrights 2025-01-01T19:22:09+00:00 Paul Eggert eggert@cs.ucla.edu 2025-01-01T18:14:45+00:00 2642002380aafb71a1d3b569b6d7ebeab3284816 






Update copyright dates with scripts/update-copyrights
2024-01-01T18:53:40+00:00

Paul Eggert
eggert@cs.ucla.edu

2024-01-01T18:12:26+00:00

dff8da6b3e89b986bb7f6b1ec18cf65d5972e307












debug: Add regression tests for BZ 30932
2023-10-04T11:07:43+00:00

Adhemerval Zanella
adhemerval.zanella@linaro.org

2023-10-03T18:09:36+00:00

be7a5468d4f694ee8d052b537141f51af43ca7f2

Checked on x86_64-linux-gnu.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>





Checked on x86_64-linux-gnu.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>