From 97a4d32ec6b8e1ea688b2ccd8ba54b8597227c79 Mon Sep 17 00:00:00 2001 From: Bryce McKinlay Date: Wed, 14 Feb 2001 05:32:31 +0000 Subject: natClass.cc (getSignature): Don't try to dereference param_types if it is null. * java/lang/natClass.cc (getSignature): Don't try to dereference param_types if it is null. Instead, take this to mean "no parameters". * java/lang/TreeMap.java (TreeIterator.next): Throw NoSuchElementException in preference to ConcurrentModificationException. (TreeIterator.remove): Throw IllegalStateException in preference to ConcurrentModificationException. (SubMap.firstKey): Do a better check for empty SubMap, and if it is, throw a NoSuchElementException. (SubMap.lastKey): Likewise. From-SVN: r39658 --- libjava/java/util/TreeMap.java | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) (limited to 'libjava/java/util/TreeMap.java') diff --git a/libjava/java/util/TreeMap.java b/libjava/java/util/TreeMap.java index ce111053299..5057d16fede 100644 --- a/libjava/java/util/TreeMap.java +++ b/libjava/java/util/TreeMap.java @@ -56,7 +56,7 @@ import java.io.IOException; * * @author Jon Zeppieri * @author Bryce McKinlay - * @modified $Id: TreeMap.java,v 1.8 2000/10/26 10:19:01 bryce Exp $ + * @modified $Id: TreeMap.java,v 1.1 2001/02/14 04:44:21 bryce Exp $ */ public class TreeMap extends AbstractMap implements SortedMap, Cloneable, Serializable @@ -1194,10 +1194,10 @@ public class TreeMap extends AbstractMap public Object next() { - if (knownMod != TreeMap.this.modCount) - throw new ConcurrentModificationException(); if (next == nil) throw new NoSuchElementException(); + if (knownMod != TreeMap.this.modCount) + throw new ConcurrentModificationException(); Node n = next; // Check limit in case we are iterating through a submap. @@ -1217,11 +1217,10 @@ public class TreeMap extends AbstractMap public void remove() { - if (knownMod != TreeMap.this.modCount) - throw new ConcurrentModificationException(); - if (last == null) throw new IllegalStateException(); + if (knownMod != TreeMap.this.modCount) + throw new ConcurrentModificationException(); /* Object key = null; if (next != nil) @@ -1408,19 +1407,17 @@ public class TreeMap extends AbstractMap public Object firstKey() { Node node = lowestGreaterThan(minKey); - // Do a range check in case SubMap is empty. - if (keyInRange(node.key)) - return node.key; - return null; + if (node == nil || !keyInRange(node.key)) + throw new NoSuchElementException ("empty"); + return node.key; } public Object lastKey() { Node node = highestLessThan(maxKey); - // Do a range check in case SubMap is empty. - if (keyInRange(node.key)) - return node.key; - return null; + if (node == nil || !keyInRange(node.key)) + throw new NoSuchElementException ("empty"); + return node.key; } public SortedMap subMap(Object fromKey, Object toKey) -- cgit v1.2.3