busybox.git/shell/shell_common.c, branch master

shell: fix race between signal handlers setting bb_got_signal and poll()

2025-07-02T20:42:47+00:00

function                                             old     new   delta
__ppoll_time64                                         -     211    +211
check_got_signal_and_poll                              -     164    +164
read_key                                             607     601      -6
shell_builtin_read                                  1328    1318     -10
------------------------------------------------------------------------------
(add/remove: 4/0 grow/shrink: 0/2 up/down: 375/-16)           Total: 359 bytes

Signed-off-by: Denys Vlasenko

use pollfd[1] array for poll() argument

2025-07-02T19:55:42+00:00

Signed-off-by: Denys Vlasenko

shell: improve bash compatibility of read built-in

2025-07-01T18:21:37+00:00

Make the read built-in more compatible with bash:

- Return an exit code of 142 on timeout.

- When the timeout expires before a newline is detected in the
  input bash captures the partial input.  This behaviour is new
  since bash version 4.4.  BusyBox shells had the pre-4.4 behaviour
  where the input was lost.

Update the tests to suit and fix a couple of compiler errors in
the testsuite.

function                                             old     new   delta
builtin_read                                         154     174     +20
readcmd                                              213     228     +15
shell_builtin_read                                  1364    1370      +6
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/0 up/down: 41/0)               Total: 41 bytes

Signed-off-by: Ron Yorston 
Signed-off-by: Denys Vlasenko

shell: move varcmp() to shell_common.h and use it in hush

2023-06-17T19:13:13+00:00

function                                             old     new   delta
unset_local_var                                        -     112    +112
findvar                                               31      35      +4
set_vars_and_save_old                                144     141      -3
helper_export_local                                  235     230      -5
set_local_var                                        425     416      -9
handle_changed_special_names                          38      27     -11
builtin_unset                                        154     141     -13
builtin_getopts                                      404     391     -13
get_local_var_value                                  281     260     -21
get_ptr_to_local_var                                  71      45     -26
unset_local_var_len                                  139       -    -139
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 1/8 up/down: 116/-240)         Total: -124 bytes

Signed-off-by: Denys Vlasenko

shell/read: do not allow empty variable name

2023-06-17T17:52:20+00:00

Signed-off-by: Denys Vlasenko

shell: add comments about SIGINT-related problems

2022-01-16T22:54:46+00:00

Signed-off-by: Denys Vlasenko

shells: do not allow bare "read" in non-bash compat configs

2021-06-06T10:08:43+00:00

    On Sat, Feb 9, 2019 Cristian Ionescu-Idbohrn wrote:
    > In my case (at work), I have to watch and prevent people from doing
    > unportable things.  For me, that's a burden.

Signed-off-by: Denys Vlasenko

shell: also do word splitting when -d DELIM is used

2021-06-05T16:06:47+00:00

The original commit 3bef5d89b0 introduced an additional check
for an unset `opt_d` before doing word splitting. I'm unsure
why it's there in the first place, but the commit message also
describes a different behaviour than what -d actually does in
bash, while the code mostly does the right thing.

`opt_d` sets the line delimiter for read to stop reading and
should not affect word splitting.

Testcase:
$ echo qwe rty | { read -d Z a b; echo a:$a b:$b; }
a:qwe b:rty

function                                             old     new   delta
shell_builtin_read                                  1314    1304     -10

Signed-off-by: Eicke Herbertz 
Signed-off-by: Denys Vlasenko

shells: a fix for systems without RLIMIT_NICE

2020-12-17T11:07:54+00:00

Signed-off-by: Denys Vlasenko

decrease paddign: gcc-9.3.1 slaps 32-byte alignment on arrays willy-nilly

2020-11-30T12:03:03+00:00

   text	   data	    bss	    dec	    hex	filename
1021988	    559	   5052	1027599	  fae0f	busybox_old
1021236	    559	   5052	1026847	  fab1f	busybox_unstripped

Signed-off-by: Denys Vlasenko