busybox.git, branch 1_34_stable

Bump version to 1.34.1

2021-09-30T20:27:55+00:00

Signed-off-by: Denys Vlasenko

awk: never return NULL from awk_printf()

2021-09-29T22:15:44+00:00

function                                             old     new   delta
awk_printf                                           651     628     -23

Signed-off-by: Denys Vlasenko

awk: code shrink

2021-09-29T22:15:44+00:00

function                                             old     new   delta
awk_printf                                           652     651      -1

Signed-off-by: Denys Vlasenko

awk: code shrink: avoid duplicate NUL checks and strlen()

2021-09-29T22:15:44+00:00

function                                             old     new   delta
awk_printf                                           665     652     -13

Signed-off-by: Denys Vlasenko

awk: fix read beyond end of buffer

2021-09-29T22:15:44+00:00

Commit 7d06d6e18 (awk: fix printf %%) can cause awk printf to read
beyond the end of a strduped buffer:

  2349      while (*f && *f != '%')
  2350          f++;
  2351      c = *++f;

If the loop terminates because a NUL character is detected the
character after the NUL is read.  This can result in failures
depending on the value of that character.

function                                             old     new   delta
awk_printf                                           672     665      -7

Signed-off-by: Ron Yorston 
Signed-off-by: Denys Vlasenko

chat: hopefully fix infinite spinning on input EOF

2021-09-29T22:15:44+00:00

function                                             old     new   delta
chat_main                                           1295    1303      +8

Signed-off-by: Denys Vlasenko

awk: fix printf %%

2021-09-29T22:15:44+00:00

A refactor of the awk printf code in
e2e3802987266c98df0efdf40ad5da4b07df0113
appears to have broken the printf interpretation of two percent signs,
which normally outputs only one percent sign.

The patch below brings busybox awk printf behavior back into alignment
with the pre-e2e380 behavior, the busybox printf util, and other common
(awk and non-awk) printf implementations.

function                                             old     new   delta
awk_printf                                           626     672     +46

Signed-off-by: Daniel Thau 
Signed-off-by: Denys Vlasenko

ash: regressions in process substitution

2021-09-29T22:15:33+00:00

Stacy Harper reports that this script:

   test() { . /tmp/bb_test; }
   echo "export TEST=foo" >/tmp/bb_test
   test 2>/dev/null
   echo "$TEST"

correctly prints 'foo' in BusyBox 1.33 but hangs in 1.34.

Bisection suggested the problem was caused by commit a1b0d3856 (ash: add
process substitution in bash-compatibility mode).  Removing the call to
unwindredir() in cmdloop() introduced in that commit makes the script
work again.

Additionally, these examples of process substitution:

   while true; do cat <(echo hi); done
   f() { while true; do cat <(echo hi); done }
   f

result in running out of file descriptors.  This is a regression from
v5 of the process substitution patch caused by changes to evalcommand()
not being transferred to v6.

function                                             old     new   delta
static.pushredir                                       -      99     +99
evalcommand                                         1729    1750     +21
exitreset                                             69      86     +17
cmdloop                                              372     365      -7
unwindredir                                           28       -     -28
pushredir                                            112       -    -112
------------------------------------------------------------------------------
(add/remove: 1/2 grow/shrink: 2/1 up/down: 137/-147)          Total: -10 bytes

Signed-off-by: Ron Yorston 
Signed-off-by: Denys Vlasenko

udhcp: fix build breakage on MIPS

2021-08-20T11:35:54+00:00

Signed-off-by: Denys Vlasenko

Bump version to 1.34.0

2021-08-19T13:04:39+00:00

Signed-off-by: Denys Vlasenko